[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8262002: java/lang/instrument/VerifyLocalVariableTableOnRetransformTest.sh failed with
From:       Coleen Phillimore <coleenp () openjdk ! java ! net>
Date:       2021-04-27 22:29:08
Message-ID: WCyAdoZntftqPWK2nWtWznsI8qkRKVnS-ru4_lWofIM=.6de4ce9a-fe2c-412a-83cf-ca263ce70777 () github ! com
[Download RAW message or body]

On Wed, 21 Apr 2021 20:51:49 GMT, Alex Menkov <amenkov@openjdk.org> wrote:

> > The test actually failed starting from jdk13, but the error is masked by \
> > JDK-8264667 (and shell part of the test didn't verify result of the java \
> > execution) The fix:
> > - updates JvmtiClassFileReconstituter to add attributes in the same order as \
> >                 javac does
> > - makes the test java instead of shell
> > - added workaround for JDK-8264667
> > - test code is ready to ignore order of attributes
> 
> Alex Menkov has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Updated the fix accordingly feedback

Looks good and great to replace the shell file in the process.

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3426


[prev in list] [next in list] [prev in thread] [next in thread]