[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8266038: Move newAddress() to JVMDebugger
From:       Kevin Walls <kevinw () openjdk ! java ! net>
Date:       2021-04-27 12:32:33
Message-ID: u3ahqqHbzN5ylJ06NyL9_2QmnV4ujkgs6vgQNcyX9dI=.640bb4e4-f9c0-43bf-82f1-38beb21de8f6 () github ! com
[Download RAW message or body]

On Tue, 27 Apr 2021 09:19:34 GMT, Yasumasa Suenaga <ysuenaga@openjdk.org> wrote:

> SA has `newAddress()` to create `Address` instance, however it is declared in each \
> debugger classes (e.g. `LinuxDebugger`). So we can't access it directly from `VM` \
> class. 
> Before SA improvement for ZGC in \
> [JDK-8220624](https://bugs.openjdk.java.net/browse/JDK-8220624), we need to move \
> `newAddress()` to super class (`JVMDebugger`).

Marked as reviewed by kevinw (Committer).

Moving this common method up the hierarchy looks good to me.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3714


[prev in list] [next in list] [prev in thread] [next in thread]