[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8264285: Clean the modification of ccstr JVM flags [v2]
From:       Ioi Lam <iklam () openjdk ! java ! net>
Date:       2021-03-31 22:53:29
Message-ID: Nl6ac7ftjBIHUmD3cn6FLWi5e_GW9M7ePsIQiyY49cQ=.e0d31254-5739-43c1-8186-8f6db3ead632 () github ! com
[Download RAW message or body]

On Tue, 30 Mar 2021 03:44:26 GMT, David Holmes <dholmes@openjdk.org> wrote:

> > Ioi Lam has updated the pull request incrementally with one additional commit \
> > since the last revision: 
> > relax flag attributions (ala JDK-7123237)
> 
> src/hotspot/share/services/writeableFlags.cpp line 250:
> 
> > 248:   if (err == JVMFlag::SUCCESS) {
> > 249:     assert(value == NULL, "old value is freed automatically and not \
> >                 returned");
> > 250:   }
> 
> The whole block should be ifdef DEBUG.

Since this whole block can be optimized out by the C compiler in product builds, I'd \
rather leave out the `#ifdef` to avoid clutter.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3254


[prev in list] [next in list] [prev in thread] [next in thread]