[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8264193: Remove TRAPS parameters for modules and defaultmethods
From:       Harold Seigel <hseigel () openjdk ! java ! net>
Date:       2021-03-30 12:16:31
Message-ID: 3SIedhLpUax0_zUv_0UU6Qokqi8YiatPxwgCvGKbJYM=.c89d8306-e980-4268-a51c-54e76b1bc16d () github ! com
[Download RAW message or body]

On Tue, 30 Mar 2021 01:40:02 GMT, David Holmes <dholmes@openjdk.org> wrote:

> > Please review this change for JDK-8264193 to remove unneeded TRAPS parameters \
> > from modules and default methods files.  Besides removing TRAPS, \
> > Modules::get_named_module() was changed to return an oop instead of a jobject, \
> > removing its need for a TRAPS parameter. 
> > This change was tested with Mach5 tiers 1 and 2 on Linux, Mac OS, and Windows, \
> > and Mach5 tiers 3-5 on Linux x64. 
> > Thanks, Harold
> 
> Great cleanup Harold!
> 
> Thanks,
> David

Thanks Lois, Calvin, Coleen, and David for the reviews!

-------------

PR: https://git.openjdk.java.net/jdk/pull/3247


[prev in list] [next in list] [prev in thread] [next in thread]