[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Integrated: 8262157: LingeredApp.startAppExactJvmOpts does not print app output when launching fails
From:       Yumin Qi <minqi () openjdk ! java ! net>
Date:       2021-02-24 0:34:41
Message-ID: XCs8dGAWdI_iEopbB1KnJQxi356WZR3l-k3yNCmnIzs=.4d3397d9-cc3e-41e0-aecf-3cbdee17b7a6 () github ! com
[Download RAW message or body]

On Mon, 22 Feb 2021 22:26:50 GMT, Yumin Qi <minqi@openjdk.org> wrote:

> Hi, Please review
> 
> When debugging for other test case which uses jcmd to attach LingeredApp process, \
> found there is no error information logged when the app started with function \
> 'startAppExactJvmOpts' exits due to some reason. This is not convenient for trace \
> what is the app failure. This simple fix for adding finishApp to print out error \
> information when LingeredApp could not start with startAppExactJvmOpts, this is \
> similar to startApp. 
> Tests: This is a simple fix and done tests with test/jdk/sun/tools/jinfo which uses \
> the function startAppExactJvmOpts to create LingeredApp, also the test case in \
> debugging, which indeed captured the error message upon start error. 
> Thanks
> Yumin

This pull request has now been integrated.

Changeset: 3e13b66e
Author:    Yumin Qi <minqi@openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/3e13b66e
Stats:     17 lines in 1 file changed: 8 ins; 7 del; 2 mod

8262157: LingeredApp.startAppExactJvmOpts does not print app output when launching \
fails

Reviewed-by: iklam, cjplummer

-------------

PR: https://git.openjdk.java.net/jdk/pull/2679


[prev in list] [next in list] [prev in thread] [next in thread]