[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8224775: test/jdk/com/sun/jdi/JdwpListenTest.java failed to attach [v2]
From:       Daniel Fuchs <dfuchs () openjdk ! java ! net>
Date:       2021-02-23 10:50:41
Message-ID: _AqYCxXzBjry4HdfMHHNs6-h1R9aYP4rMpHHa-Fw2B8=.381843d8-9881-481a-a001-6bc1e4bfbf8c () github ! com
[Download RAW message or body]

On Mon, 22 Feb 2021 21:36:52 GMT, Alex Menkov <amenkov@openjdk.org> wrote:

> > The fix also partially fixes JdwpAttachTest failures (JDK-8253940).
> > The failures are caused by network configuration changes during test execution \
> > ("global" IPv6 addresses disappears from interface). To minimize chances of \
> > intermittent failures like this java.net tests use only link-local addresses \
> > whenever possible. The fix does the same for JDI tests \
> > (Utils.getAddressesWithSymbolicAndNumericScopes  is used by JdwpListenTest and \
> > JdwpAttachTest)
> 
> Alex Menkov has updated the pull request incrementally with one additional commit \
> since the last revision: 
> include loopback addresses in testing

The last changes look good to me.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2633


[prev in list] [next in list] [prev in thread] [next in thread]