[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Integrated: 8261857: serviceability/sa/ClhsdbPrintAll.java failed with "Test ERROR java.lang.Runtime
From:       Chris Plummer <cjplummer () openjdk ! java ! net>
Date:       2021-02-20 20:49:41
Message-ID: jSgdwL2BTru6zJiz7GEEjXdCv4Iuz8EP4MuqWsoVW2E=.f2265eac-06f6-4384-b5f6-48dcfc9ceaca () github ! com
[Download RAW message or body]

On Thu, 18 Feb 2021 06:13:27 GMT, Chris Plummer <cjplummer@openjdk.org> wrote:

> The test is checking for "cannot be cast to" because at one point there was a bug \
> in `printall` that was causing a `ClassCastException`. See \
> [JDK-8175384](https://bugs.openjdk.java.net/browse/JDK-8175384). However, there is \
> also a "cannot be cast to" message in the `printall` output when disassembling \
> since the java source actually has it in a string literal: 
> 3203 302 ldc #214(6) <String " cannot be cast to ResourceBundle"> [fast_aldc]
> 
> Which comes from the following in the ResourceBundle.java source:
> 
> throw new ClassCastException(c.getName()
> + " cannot be cast to ResourceBundle"); 
> 
> So this occurrence of "cannot be cast" is fine. The one we don't want comes from \
> `SharedRuntime::generate_class_cast_message()` in `sharedRuntime.cpp`: 
> `                 "class %s cannot be cast to class %s (%s%s%s)",`
> 
> So we can avoid this bug by changing the check to be a bit more explicit and check \
> for "cannot be cast to class" instead.

This pull request has now been integrated.

Changeset: c2509ea9
Author:    Chris Plummer <cjplummer@openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/c2509ea9
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8261857: serviceability/sa/ClhsdbPrintAll.java failed with "Test ERROR \
java.lang.RuntimeException: 'cannot be cast to' found in stdout"

Reviewed-by: sspitsyn

-------------

PR: https://git.openjdk.java.net/jdk/pull/2624


[prev in list] [next in list] [prev in thread] [next in thread]