[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8257988: Remove JNF dependency from libsaproc/MacosxDebuggerLocal.m
From:       Phil Race <prr () openjdk ! java ! net>
Date:       2021-01-30 18:11:41
Message-ID: nZ_foBSVvxq5kOt85GXQ9zWLvJzYymvCxQOZ8YaRvG4=.f7c4f5c1-3fff-491a-a64a-14219b4e42ae () github ! com
[Download RAW message or body]

On Fri, 29 Jan 2021 17:22:49 GMT, Phil Race <prr@openjdk.org> wrote:

> > Build changes look good.
> 
> > Is it because they are not in a place that can be accessed from this file?
> Right 99% of JNF usage was the desktop module many, many files, 1300 references .. \
> the entire rest of the JDK had just 3 files each in a different module ! It did not \
> seem worth creating a JDK-wide platform-specific library to support this.

> For testing you want test/jdk/sun/tools/jhsdb/ and \
> test/hotspot/jtreg/serviceability/sa

These tests passed with my changes

-------------

PR: https://git.openjdk.java.net/jdk/pull/2304


[prev in list] [next in list] [prev in thread] [next in thread]