[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8251462: Remove legacy compilation policy [v5]
From:       David Holmes <david.holmes () oracle ! com>
Date:       2021-01-28 4:44:13
Message-ID: 7a846651-9ffe-eacd-af93-91f2e545b059 () oracle ! com
[Download RAW message or body]

Hi Igor,

On 28/01/2021 2:46 am, Igor Veresov wrote:
> On Mon, 25 Jan 2021 18:13:20 GMT, Igor Veresov <iveresov@openjdk.org> wrote:
> 
> > > Looks better now. I would like to see result of performance testing before \
> > > approving.
> > 
> > I asked Eric to run the benchmarks. The results should be ready on Wednesday.
> 
> The benchmarking is done. No regressions. There are mild improvements in startup \
> benchmarks on the order of 1-5% (I suspect because of the compilation policy \
> devirtualization). 
> @dholmes-ora, do still plan to look at this? It's been a few weeks, I'd like to \
> push this.

No I only perused this and made a couple of comments, now addressed.

I'll leave a full review to others.

Thanks,
David

> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/1985
> 


[prev in list] [next in list] [prev in thread] [next in thread]