[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Integrated: 8165276: Spec states to invoke the premain method in an agent class if it's public but i
From:       Serguei Spitsyn <sspitsyn () openjdk ! java ! net>
Date:       2021-01-26 7:18:44
Message-ID: whnHXMx-PjJwoPR1Gzs3fzy3vJprlmbP981OOtpsM3A=.c2d605b6-6283-4c9d-901b-9d317c065181 () github ! com
[Download RAW message or body]

On Tue, 8 Dec 2020 11:41:33 GMT, Serguei Spitsyn <sspitsyn@openjdk.org> wrote:

> This change have been already reviewed by Mandy, Sundar, Alan and David.
> Please, see the jdk 15 review thread:
> http://mail.openjdk.java.net/pipermail/serviceability-dev/2020-June/031998.html
> 
> Now, the PR approval is needed.
> The push was postponed because the CSR was not approved at that time (it is now):
> https://bugs.openjdk.java.net/browse/JDK-8248189
> Investigation of existing popular java agents was requested by Joe.
> ----------
> 
> The java.lang.instrument spec:
> https://docs.oracle.com/en/java/javase/15/docs/api/java.instrument/java/lang/instrument/package-summary.html
>  
> Summary:
> The java.lang.instrument spec clearly states:
> "The agent class must implement a public static premain method
> similar in principle to the main application entry point."
> Current implementation of sun/instrument/InstrumentationImpl.java
> allows the premain method be non-public which violates the spec.
> This fix aligns the implementation with the spec.
> 
> Testing:
> A mach5 run of jdk_instrument tests is in progress.

This pull request has now been integrated.

Changeset: c538cd8b
Author:    Serguei Spitsyn <sspitsyn@openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/c538cd8b
Stats:     496 lines in 23 files changed: 223 ins; 172 del; 101 mod

8165276: Spec states to invoke the premain method in an agent class if it's public \
but implementation differs

Reviewed-by: mchung, dholmes, alanb

-------------

PR: https://git.openjdk.java.net/jdk/pull/1694


[prev in list] [next in list] [prev in thread] [next in thread]