[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8231627: runtime/ErrorHandling/ThreadsListHandleInErrorHandlingTest.java fails because
From:       Erik =?UTF-8?B?w5ZzdGVybHVuZA==?= <eosterlund () openjdk ! java ! net>
Date:       2020-12-24 22:17:59
Message-ID: PExib_Qk_R4N1ggWYNsJv694FSt8zb6ANZXqjxb7xao=.1b5bd769-90fa-42c8-8257-247f1d004318 () github ! com
[Download RAW message or body]

On Thu, 24 Dec 2020 22:01:38 GMT, Erik Österlund <eosterlund@openjdk.org> wrote:

>> A small robustness fix in ThreadsSMRSupport::print_info_on() to reduce the
>> likelihood of crashes during error reporting. Uses Threads_lock->try_lock()
>> for safety and restricts some reporting to when the Threads_lock has been
>> acquired (depends on JDK-8256383). Uses a ThreadsListHandle to make
>> the current ThreadsList safe for reporting (depends on JDK-8258284). Also
>> detects when the system ThreadsList (_java_thread_list) has changed and
>> will warn that some of the reported info may now be stale.
>> 
>> Two existing tests have been updated to reflect the use of a ThreadsListHandle
>> in ThreadsSMRSupport::print_info_on(). Mach5 Tier[1-6] testing has no regressions.
>
> Looks good. We have something similar in the precious GC log code during error reporting.

> @fisk - Thanks for the review! And Merry Christmas Eve!!

Merry Christmas to you too Dan!

-------------

PR: https://git.openjdk.java.net/jdk/pull/1891
[prev in list] [next in list] [prev in thread] [next in thread]