[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8165276: Spec states to invoke the premain method in an agent class if it's public but impl
From:       Serguei Spitsyn <sspitsyn () openjdk ! java ! net>
Date:       2020-12-23 18:05:03
Message-ID: dgpEl4dh3y_uGFW0jkp6DzjhnCECvnQ5un1Q9CxJ3lM=.7bb4ea38-97b8-4573-bba6-ccf745a0270e () github ! com
[Download RAW message or body]

On Wed, 23 Dec 2020 14:06:27 GMT, Alan Bateman <alanb@openjdk.org> wrote:

> > Serguei Spitsyn has updated the pull request incrementally with one additional \
> > commit since the last revision: 
> > 1. Prperly reverted fixes in 3 tests; 2. Got rid of <inherited> term in tests \
> > summary comment
> 
> Thanks for persevering on this one. The updated checks look good. At some point I \
> think we re-examine the issue of allowing agents to be non-public, maybe emit a \
> warning and eventually disallow it. If/when support is added for developing and \
> deployed java agents as modules it might be the time to re-examine it.

Thank you for review, Alan!

-------------

PR: https://git.openjdk.java.net/jdk/pull/1694


[prev in list] [next in list] [prev in thread] [next in thread]