[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Integrated: 8258057: serviceability/attach/RemovingUnixDomainSocketTest.java doesn't ignore VM
From:       Patricio Chilano Mateo <pchilanomate () openjdk ! java ! net>
Date:       2020-12-17 16:44:57
Message-ID: ToSnToK7PI6a18Mm1jnmASuMRUiOCKLteO_nRAdZZAs=.0da13a85-aeac-46dc-91ba-585233ff77d8 () github ! com
[Download RAW message or body]

On Fri, 11 Dec 2020 17:25:33 GMT, Patricio Chilano Mateo <pchilanomate@openjdk.org> \
wrote:

> Hi,
> 
> Please review the following small fix for test RemovingUnixDomainSocketTest.java. \
> As explained in the bug comments, the issue is due to having two different \
> StreamPumper objects consuming from the same stderr, one created by \
> ProcessTools.startProcess() and another by OutputAnalyzer(). In the failing cases \
> the StreamPumper processing thread created in ProcessTools.startProcess() consumes \
> the first part of the deprecation message while the one created in OutputAnalyzer \
> consumes the rest. Since out.getStderr() is not empty and does not contain the \
> string "VM warning:", the test fails. 
> I simply replaced the ProcessTools.startProcess() call by a call to start() on the \
> ProcessBuilder object, which doesn't use StreamPumper. I added \
> stderrShouldBeEmptyIgnoreDeprecatedWarnings(), since as mentioned in 8248162 we \
> might not want to hide all warning messages. 
> Without the patch I can consistently reproduce the issue. With the patch the test \
> always passes. 
> Thanks,
> Patricio

This pull request has now been integrated.

Changeset: 7b05439d
Author:    Patricio Chilano Mateo <pchilanomate@openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/7b05439d
Stats:     20 lines in 2 files changed: 18 ins; 0 del; 2 mod

8258057: serviceability/attach/RemovingUnixDomainSocketTest.java doesn't ignore VM \
warnings

Reviewed-by: cjplummer, amenkov, dholmes

-------------

PR: https://git.openjdk.java.net/jdk/pull/1749


[prev in list] [next in list] [prev in thread] [next in thread]