[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8255934: JConsole 14 and greater fails to connect to older JVM
From:       Serguei Spitsyn <sspitsyn () openjdk ! java ! net>
Date:       2020-11-20 23:30:10
Message-ID: lr0tU-7u1emNIysmKZYC0jNiv5l-CErg0XYT6g2HAww=.d54899d7-f6c6-4c2f-863e-73c9cb9c1cb3 () github ! com
[Download RAW message or body]

On Mon, 16 Nov 2020 23:00:05 GMT, Alex Menkov <amenkov@openjdk.org> wrote:

> OperatingSystemMXBean was changed in jdk14 (see JDK-8226575):
> New methods getTotalMemorySize and getFreeMemorySize were added, old \
> getTotalPhysicalMemorySize and getFreePhysicalMemorySize were deprecated. 
> The fix adds fallbacks for the values (i.e. if new methods fail, jconsole calls old \
> methods)

Hi Alex,
It looks good to me.
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1243


[prev in list] [next in list] [prev in thread] [next in thread]