[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8250888: nsk/jvmti/scenarios/general_functions/GF08/gf08t001/TestDriver.java fails
From:       Aleksey Shipilev <shade () openjdk ! java ! net>
Date:       2020-11-20 7:06:06
Message-ID: hQ2H4hQk8acorphK5FjxdzoDour_-RnEV05IABhq2fA=.74bfd29e-6216-444f-af7f-0204210d5201 () github ! com
[Download RAW message or body]

On Fri, 20 Nov 2020 06:30:31 GMT, Guoxiong Li \
<github.com+13688759+lgxbslgx@openjdk.org> wrote:

> > Hi Guoxiong,
> > It looks good to me.
> > Thanks,
> > Serguei
> 
> I run the test locally using the following command before I submit this patch.
> make test TEST="jtreg:hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/general_functions/GF08/gf08t001/TestDriver.java" \
> TEST_VM_OPTS=-XX:+UseShenandoahGC This test passes which misleads me that my patch \
> is right. 
> In any case, I apologize for this mistake and will try my best to do more testing \
> before submitting patches in the future. Thank you very much for taking the time to \
> review. 
> Best Regards.

I tested this patch with Serial, Parallel, G1, Shenandoah, Z and it passes.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1319


[prev in list] [next in list] [prev in thread] [next in thread]