[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8255455: Pre-generate ThreadHeapSampler::_log_table [v7]
From:       Claes Redestad <redestad () openjdk ! java ! net>
Date:       2020-10-30 18:18:58
Message-ID: vWHn8U6C7lXJCBJhbuco_yIBj6X9ZmU_JSKertAv6y8=.83f9c492-b024-4d9f-a75c-9d7f830c3a14 () github ! com
[Download RAW message or body]

On Fri, 30 Oct 2020 17:39:05 GMT, Ioi Lam <iklam@openjdk.org> wrote:

> > Claes Redestad has updated the pull request with a new target base due to a merge \
> > or a rebase. The incremental webrev excludes the unrelated changes brought in by \
> > the merge/rebase. The pull request contains 11 additional commits since the last \
> > revision: 
> > - Merge branch 'master' into threadHeapSampler_constexpr
> > - Check log_table on startup in debug builds
> > - Add explicit include of logging
> > - Add const, fix copyright
> > - Desugar constexpr into code generator and output
> > - Merge branch 'master' into threadHeapSampler_constexpr
> > - Declare and define log_table as a static constexpr inside threadHeapSampler.cpp
> > - Merge branch 'master' into threadHeapSampler_constexpr
> > - Merge branch 'master' into threadHeapSampler_constexpr
> > - Remove _log_table_initialized assert
> > - ... and 1 more: https://git.openjdk.java.net/jdk/compare/7a199d94...0eebe57c
> 
> LGTM

@iklam: thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/880


[prev in list] [next in list] [prev in thread] [next in thread]