[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8254723: add diagnostic command to write Linux perf map file [v5]
From:       Yasumasa Suenaga <ysuenaga () openjdk ! java ! net>
Date:       2020-10-30 4:36:45
Message-ID: thEkM__KRq8ghtVwjnj9o7U5gtG2JXBWfjyyLV2zlvY=.25102ff6-8bad-458a-a071-3f2daca942a1 () github ! com
[Download RAW message or body]

On Wed, 21 Oct 2020 04:35:14 GMT, Yasumasa Suenaga <ysuenaga@openjdk.org> wrote:

> > Nick Gasson has updated the pull request incrementally with one additional commit \
> > since the last revision: 
> > Make DumpPerfMapAtExit a diagnostic option
> 
> Changes requested by ysuenaga (Reviewer).

> @YaSuenag could you re-review the latest changes?

Sure, the change looks good to me. However I don't understand why CSR is not needed. \
It introduces new dcmd for Linux.

-------------

PR: https://git.openjdk.java.net/jdk/pull/760


[prev in list] [next in list] [prev in thread] [next in thread]