[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8252117: com/sun/jdi/BadHandshakeTest.java failed with "ConnectException: Connection refuse
From:       Serguei Spitsyn <sspitsyn () openjdk ! java ! net>
Date:       2020-10-26 18:30:21
Message-ID: R5iZTuAZlfMOeuo5SwqSNWQFe8g3E_DLGbFrNChv5dQ=.8b87ea55-ae9b-47ab-97e1-8e688741a7df () github ! com
[Download RAW message or body]

On Fri, 23 Oct 2020 22:44:50 GMT, Alex Menkov <amenkov@openjdk.org> wrote:

> > Please review the fix for BadHandshakeTest.
> > Summary:
> > The test verifies that bad (testcase1) or incomplete (testcase2) handshake does \
> > not cause debuggee termination. To check this it tries to attach to the debuggee \
> > again (connect in testcase2 is also verification for testcase1) 
> > The fix adds reply logic to the last attach (similar to retry logic in testcase2)
> 
> Alex Menkov has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Fix the comment

Hi Alex,
It looks good.
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/789


[prev in list] [next in list] [prev in thread] [next in thread]