[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Integrated: 8252003: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jvmti
From:       Igor Ignatyev <iignatyev () openjdk ! java ! net>
Date:       2020-09-30 21:40:28
Message-ID: d5JJDi0Bi_vC_8TjU_oWTy4-0jkxZWn-_8Fr35IkH2o=.0f997d6a-8e7f-49b6-a8c5-0e081dbb6795 () github ! com
[Download RAW message or body]

On Fri, 25 Sep 2020 23:48:30 GMT, Igor Ignatyev <iignatyev@openjdk.org> wrote:

> Hi all,
> 
> could you please review the patch which removes `PropertyResolvingWrapper` from \
> `vmTestbase/nsk/jvmti` tests? as `jtreg` doesn't support spaces in the arguments \
>                 and doesn't handle `"` in any special ways, the patch also:
> - `s/"-javaOpts=/-javaOpts="/`
> - makes `nsk.jvmti.scenarios.general_functions.GF08` to use 2nd arg as \
> `verboseType` and 3rd and the rest args concatenated as `phrase` and updates the \
>                 tests accordingly
> - removes spaces and surrounding `"` from `nsk.jvmti.test.property*`
> - removes `"` surrounding `-agentlib:`, replaces spaces in `-agentlib` with `,` and \
> updates `ArgumentHandler` to treat `,` (as well as ` ` and `~`) as options \
> delimiters, so it's consistent w/ `jvmti_tools.cpp` 
> testing: ✅  `vmTestbase/nsk/jvmti` on {linux,windows,macos}-x64

This pull request has now been integrated.

Changeset: ca0e014e
Author:    Igor Ignatyev <iignatyev@openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/ca0e014e
Stats:     599 lines in 165 files changed: 14 ins; 149 del; 436 mod

8252003: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jvmti

Reviewed-by: cjplummer, sspitsyn

-------------

PR: https://git.openjdk.java.net/jdk/pull/370


[prev in list] [next in list] [prev in thread] [next in thread]