[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Integrated: 8252001: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jdi
From:       Igor Ignatyev <iignatyev () openjdk ! java ! net>
Date:       2020-09-30 16:21:17
Message-ID: QNoVERQbFN78ztLRY2dKdvzOOrpJt_jSjENpxMihE5k=.7c26df25-7f53-4711-8acd-920a96d5e252 () github ! com
[Download RAW message or body]

On Mon, 28 Sep 2020 14:09:59 GMT, Igor Ignatyev <iignatyev@openjdk.org> wrote:

> Hi all,
> 
> could you please review the patch which removes `PropertyResolvingWrapper` from \
> `vmTestbase/nsk/jdi`? other than the removal of `PropertyResolvingWrapper` from \
>                 jtreg actions, the patch also
> - `s/"-debugee.vmkeys=/-debugee.vmkeys="/`
> - removed `ExecDriver` there it's not needed anymore
> - as jtreg doesn't support static nested classes as main test classes, all \
> `EventTestTemplates`s inner classes were moved up and the tests were updated \
>                 accordingly
> - appended ${java.class.path} to `-cp` in the tests which specify classpath, \
> otherwise, these tests fail due to CNFE of jtreg tests
> - escaped `"` on windows in `nsk.share.jdi.Binder`
> - replaced default quote (`"`) w/ `\0` in `n.s.j.Binder` so there will be no \
> clashes w/ `"` from actions 
> testing: ✅ `vmTestbase/nsk/jdi` tests on `{linux,windows,macos}-x64`

This pull request has now been integrated.

Changeset: 8f7c9a7b
Author:    Igor Ignatyev <iignatyev@openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/8f7c9a7b
Stats:     3401 lines in 1157 files changed: 588 ins; 397 del; 2416 mod

8252001: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jdi

Reviewed-by: cjplummer, sspitsyn

-------------

PR: https://git.openjdk.java.net/jdk/pull/379


[prev in list] [next in list] [prev in thread] [next in thread]