[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8253815: Remove unused HeapRegionManager::_num_committed from SA
From:       Stefan Johansson <sjohanss () openjdk ! java ! net>
Date:       2020-09-29 21:36:53
Message-ID: mri39oqX0u0qie3TRddOLwXE1KYX6CLSv6W6KvIelq4=.ab1a565a-8456-41f5-932a-acfc4280ac72 () github ! com
[Download RAW message or body]

On Tue, 29 Sep 2020 21:32:07 GMT, Chris Plummer <cjplummer@openjdk.org> wrote:

> > The field will remain for now, but the plan is to refactor it into a new class. \
> > The new class is not needed by the SA and I would really like to avoid having to \
> > add unused and untested code to the SA. To simplify this coming change I want to \
> > remove this from the SA straight away.   Even without this coming change I would \
> > vote for removing this type of unused code from the SA. I don't think being able \
> > to dump the value is worth enough compared to the maintenance cost of keeping it \
> > in.
> 
> Ok. If the field is going away eventually then you can remove it now.

Awesome, thanks for reviewing.

-------------

PR: https://git.openjdk.java.net/jdk/pull/408


[prev in list] [next in list] [prev in thread] [next in thread]