[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8238761: Asynchronous handshakes [v9]
From:       Robbin Ehn <rehn () openjdk ! java ! net>
Date:       2020-09-29 8:57:41
Message-ID: rxYu9Ctf0U6tkrxsfWEiKNEap0EtddbA8irFQ2HE7F0=.730b5993-bc53-4eb2-b166-bcbd1f92bc9e () github ! com
[Download RAW message or body]

On Tue, 29 Sep 2020 06:25:40 GMT, David Holmes <dholmes@openjdk.org> wrote:

> > Robbin Ehn has updated the pull request with a new target base due to a merge or \
> > a rebase. The incremental webrev excludes the unrelated changes brought in by the \
> > merge/rebase. The pull request contains 11 additional commits since the last \
> >                 revision:
> > - More fixes from David
> > - Merge branch 'master' into 8238761-asynchrounous-handshakes
> > - Add constructor and comment. Previous renames caused confusing, improved names \
> >                 once more and moved non-public to private
> > - Fixed trailing whitespace
> > - Update after David
> > - Update after Coleen
> > - Update after Dan and David
> > - Merge branch 'master' into 8238761-asynchrounous-handshakes
> > - Removed double check, fix comment, removed not needed function, updated logs
> > - Fixed double checks
> > Added NSV
> > ProcessResult to enum
> > Fixed logging
> > Moved _active_handshaker to private
> > - ... and 1 more: https://git.openjdk.java.net/jdk/compare/5335e46d...3a95750e
> 
> Hi Robbin,
> Thanks for the updates and the slack chat to clarify my misunderstanding of the \
> queuing mechanism. 
> I agree that the logging statements are somewhat confusing as they were written \
> when the processing logic was much simpler, but I understand now the count of \
> emitted executed operations. This all looks good to me now.
> Thanks,
> David

Thanks all!

-------------

PR: https://git.openjdk.java.net/jdk/pull/151


[prev in list] [next in list] [prev in thread] [next in thread]