[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8251999: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/aod
From:       Igor Ignatyev <iignatyev () openjdk ! java ! net>
Date:       2020-09-24 16:34:59
Message-ID: 4eMJC63RqJlYM4Kl-9cCNygqZujViNh6JSeKgp0qIqM=.5aad0f6d-877e-469f-a9f4-d1acdaaa9d11 () github ! com
[Download RAW message or body]

On Wed, 23 Sep 2020 05:35:29 GMT, Aleksey Shipilev <shade@openjdk.org> wrote:

> > the patch
> > - removes `PropertyResolvingWrapper` from `vmTestbase/nsk/aod` tests
> > - updates `AODRunnerArgParser` to remove surrounding `"` symbols from `javaOpts` \
> >                 option values
> > - updates vmTestbase/nsk/aod test descriptions to have `"` in `javaOpts` values \
> > (as opposed of around `-javaOpts=$value` as it's now)
> > - mechanically reformats/cleans up the tests (whitespaces, imports, etc)
> > 
> > testing:
> > * [x] vmTestbase/nsk/aod on  {macosx,windows,linux}-x64
> > * [x] vmTestbase/nsk/aod on macosx-x64 w/ `VM_OPTIONS`, `JAVA_OPTIONS` being \
> > empty and having value
> 
> Looks good, modulo minor comments below.

@shipilev , @sspitsyn, thanks for your reviews.

-------------

PR: https://git.openjdk.java.net/jdk/pull/311


[prev in list] [next in list] [prev in thread] [next in thread]