[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(S) : 8252402 : rewrite vmTestbase/nsk/jvmti/Allocate/alloc001 shell test to Java
From:       Alex Menkov <alexey.menkov () oracle ! com>
Date:       2020-08-31 22:37:17
Message-ID: 87aa2d79-d411-4787-45b8-9c1824834a10 () oracle ! com
[Download RAW message or body]

I suppose with WSL cygwin is not required.
But it should be OK as well.
LGTM.

--alex

On 08/31/2020 15:03, Igor Ignatyev wrote:
> Hi Alex,
> 
> AFAIK, cygwin always was and still is a requirement for both building and testing \
> on windows, so it should not be a problem for anyone who is developing/testing \
> OpenJDK on windows. 
> Cheers,
> -- Igor
> 
> > On Aug 31, 2020, at 2:54 PM, Alex Menkov <alexey.menkov@oracle.com> wrote:
> > 
> > Hi Igor,
> > 
> > Looks good in general.
> > One question.
> > As far as I see old test didn't run "sh ulimit" on Windows.
> > So now the test requires cygwin to run?
> > 
> > --alex
> > 
> > On 08/31/2020 12:03, Igor Ignatyev wrote:
> > > ping?
> > > > On Aug 26, 2020, at 4:59 PM, Igor Ignatyev <igor.ignatyev@oracle.com> wrote:
> > > > 
> > > > http://cr.openjdk.java.net/~iignatyev//8252402/webrev.00
> > > > > 287 lines changed: 60 ins; 200 del; 27 mod;
> > > > 
> > > > Hi all,
> > > > 
> > > > could you please review the patch which removes shell script from alloc001 \
> > > > test? there are two small difference comparing to the original test:
> > > > - if we don't get OutOfMemory on mac or windows, the test will be reported as \
> > > >                 skipped (as opposed to passed-passed before)
> > > > - as changing DYLD_LIBRARY_PATH on mac is a bit cumbersome due to SIP, I \
> > > > decided to use '-agentpath:' instead of '-agentlib:' 
> > > > the patch also moves alloc001.java to closer to the other files \
> > > > (vmTestbase/nsk/jvmti/Allocate/alloc001), removes TestDescription.java file, \
> > > > moves jtreg test description to the test source code and removes printdump \
> > > > agent option making trace messages in alloc001.cpp unconditional. 
> > > > webrev: http://cr.openjdk.java.net/~iignatyev//8252402/webrev.00 (depends on \
> > > >                 8252401[1,2])
> > > > JBS: https://bugs.openjdk.java.net/browse/JDK-8252402
> > > > testing: vmTestbase/nsk/jvmti/Allocate/alloc001 on {linux,windows,macos}-x64
> > > > 
> > > > [1] https://bugs.openjdk.java.net/browse/JDK-8252401
> > > > [2] http://cr.openjdk.java.net/~iignatyev//8252401/webrev.00
> > > > 
> > > > Thanks,
> > > > -- Igor
> > > > 
> 


[prev in list] [next in list] [prev in thread] [next in thread]