[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: URGENT RFR(T): 8252551: JDK-8250630 causes build error on Win*
From:       "Daniel D. Daugherty" <daniel.daugherty () oracle ! com>
Date:       2020-08-30 16:46:40
Message-ID: 0dc3c267-f2b6-08ba-65b9-b7d81e658cc0 () oracle ! com
[Download RAW message or body]

Thanks for the fast review!

Pushed.

Dan


On 8/30/20 12:29 PM, Dmitry Samersoff wrote:
> Hello Dan,
>
> Looks good to me.
>
> Thank you for fixing it.
>
> -Dmitry
>
> On 8/30/2020 7:18 PM, Daniel D. Daugherty wrote:
>> Greetings,
>>
>> I have a trivial fix for the following build breaking bug:
>>
>>      JDK-8252551 JDK-8250630 causes build error on Win*
>>      https://bugs.openjdk.java.net/browse/JDK-8252551
>>
>> Here's the context diffs for the fix:
>>
>> $ hg diff
>> diff -r d7707af10c98 
>> src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c
>> --- a/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c 
>> Sun Aug 30 15:48:16 2020 +0300
>> +++ b/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c 
>> Sun Aug 30 11:37:39 2020 -0400
>> @@ -716,7 +716,6 @@
>>                                  char** actualAddress)
>>   {
>>       int err;
>> -    int pass;
>>       struct addrinfo *addrInfo = NULL;
>>       struct addrinfo *listenAddr = NULL;
>>       struct addrinfo *ai = NULL;
>>
>>
>> The fix is being tested by a Mach5 Tier3 job set.
>>
>> Thanks, in advance, for any comments, questions or suggestions.
>>
>> Dan
>>
>

[prev in list] [next in list] [prev in thread] [next in thread]