[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR(s):8251848: JMap.histo() and JMap.dump() should parse sub-arguments similarly(Internet mail)
From: "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date: 2020-08-24 20:17:27
Message-ID: 56a59a8f-8402-173e-dc84-13878d2c43eb () oracle ! com
[Download RAW message or body]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="moz-cite-prefix">Hi Lin,<br>
<br>
LGTM++<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
On 8/24/20 11:44, <a class="moz-txt-link-abbreviated" \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a> wrote:<br> \
</div> <blockquote type="cite"
cite="mid:f831d24f-578e-b895-f22f-4dcc7193324b@oracle.com">
<div class="moz-cite-prefix">Hi Paul,<br>
<br>
I tried to complete my review but the webrev is not loaded at
the moment.<br>
The server <span><a
href="http://cr.openjdk.java.net/~lzang/8251848/webrev.00/"
moz-do-not-send="true"><span>cr.openjdk.java.net</span></a>
was very slow yesterday.<br>
Will check if anything can be done on my side.<br>
<br>
Thanks,<br>
Serguei<br>
</span><br>
<br>
On 8/24/20 11:26, Hohensee, Paul wrote:<br>
</div>
<blockquote type="cite"
cite="mid:68B4CE59-C101-4489-8EAD-ECB049AC2A45@amazon.com">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<div class="WordSection1">
<p class="MsoNormal">Needs another review. I can push it for
you after that.</p>
<p class="MsoNormal"> </p>
<p class="MsoNormal">Paul</p>
<p class="MsoNormal"> </p>
<div>
<p class="MsoNormal"><b><span>From: \
</span></b><span>"linzang(</span><span>臧琳</span><span>)" <a \
class="moz-txt-link-rfc2396E" href="mailto:linzang@tencent.com"
moz-do-not-send="true"><linzang@tencent.com></a><br>
<b>Date: </b>Sunday, August 23, 2020 at 6:58 PM<br>
<b>To: </b>"Hohensee, Paul" <a
class="moz-txt-link-rfc2396E"
href="mailto:hohensee@amazon.com"
moz-do-not-send="true"><hohensee@amazon.com></a>,
<a class="moz-txt-link-rfc2396E"
href="mailto:serviceability-dev@openjdk.java.net"
moz-do-not-send="true">"serviceability-dev@openjdk.java.net"</a>
<a class="moz-txt-link-rfc2396E"
href="mailto:serviceability-dev@openjdk.java.net"
moz-do-not-send="true"><serviceability-dev@openjdk.java.net></a><br>
<b>Subject: </b>RE: [EXTERNAL] RFR(s):8251848:
JMap.histo() and JMap.dump() should parse sub-arguments
similarly(Internet mail)</span><span></span></p>
</div>
<div>
<p>Dear Paul, </p>
<p> Thanks a lot! may I ask your help to push it if
there is no need for more review?</p>
<p>Cheers,</p>
<p>Lin</p>
<div>
<p class="MsoNormal">On 22/08/2020 04:33, Hohensee, Paul
wrote:</p>
</div>
<blockquote>
<p class="MsoNormal">Lgtm.</p>
<p class="MsoNormal"> </p>
<p class="MsoNormal">Paul</p>
<p class="MsoNormal"> </p>
<div>
<p class="MsoNormal"><b><span>From: \
</span></b><span>"linzang(</span><span>臧琳</span><span>)" <a \
href="mailto:linzang@tencent.com"
moz-do-not-send="true"><linzang@tencent.com></a><br>
<b>Date: </b>Thursday, August 20, 2020 at 5:03 PM<br>
<b>To: </b><a
href="mailto:serviceability-dev@openjdk.java.net"
\
moz-do-not-send="true">"serviceability-dev@openjdk.java.net"</a> <a \
href="mailto:serviceability-dev@openjdk.java.net"
\
moz-do-not-send="true"><serviceability-dev@openjdk.java.net></a>, "Hohensee, \
Paul" <a href="mailto:hohensee@amazon.com"
moz-do-not-send="true"><hohensee@amazon.com></a><br>
<b>Subject: </b>RFR(s):8251848: JMap.histo() and
JMap.dump() should parse sub-arguments similarly</span></p>
</div>
<p class="MsoNormal"> </p>
<div>
<p class="MsoNormal"><span>Dear All, </span></p>
<p class="MsoNormal"><span> Please help review
the patch of 8251848, Thanks!</span></p>
<p class="MsoNormal"><span> Webrev: <a
href="http://cr.openjdk.java.net/~lzang/8251848/webrev.00/"
\
moz-do-not-send="true"><span>http://cr.openjdk.java.net/~lzang/8251848/webrev.00/</span></a> \
</span></p>
<p class="MsoNormal"><span> Bug:</span> <a
href="https://bugs.openjdk.java.net/browse/JDK-8251848"
moz-do-not-send="true"><span>https://bugs.openjdk.java.net/browse/JDK-8251848</span></a>
<span> </span></p>
<p class="MsoNormal"><span>BRs,</span></p>
<p class="MsoNormal"><span>Lin</span></p>
</div>
</blockquote>
<p> </p>
</div>
</div>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic