[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR(T) : 8252005 : narrow disabling of allowSmartActionArgs in vmTestbase
From: Igor Ignatyev <igor.ignatyev () oracle ! com>
Date: 2020-08-20 18:18:19
Message-ID: 3CB6B3FF-458B-4B76-872B-46A6D30B7A33 () oracle ! com
[Download RAW message or body]
thanks Serguei, pushed.
-- Igor
> On Aug 20, 2020, at 10:55 AM, serguei.spitsyn@oracle.com wrote:
>
> Hi Igor,
>
> Still looks good to me.
> The webrev is veeeeery slow.
>
> Thanks,
> Serguei
>
>
> On 8/20/20 10:16, Igor Ignatyev wrote:
> > Hi Serguei,
> >
> > thanks for your review. I've decided to slightly modify the patch and use the ids \
> > of subtasks in TEST.properties files (instead of main bug id) in order to avoid \
> > possible confusion in the future:
> > - incremental: http://cr.openjdk.java.net/~iignatyev//8252005/webrev.0-1/index.html \
> > <http://cr.openjdk.java.net/~iignatyev//8252005/webrev.0-1/index.html>
> >
> > - whole: http://cr.openjdk.java.net/~iignatyev//8252005/webrev.01/index.html \
> > <http://cr.openjdk.java.net/~iignatyev//8252005/webrev.01/index.html>
> > could you please re-review it?
> >
> > Thanks,
> > -- Igor
> >
> > > On Aug 19, 2020, at 4:22 PM, serguei.spitsyn@oracle.com \
> > > <mailto:serguei.spitsyn@oracle.com> wrote:
> > > Hi Igor,
> > >
> > > This looks reasonable.
> > >
> > > Thanks,
> > > Serguei
> > >
> > >
> > > On 8/18/20 16:42, Igor Ignatyev wrote:
> > > > http://cr.openjdk.java.net/~iignatyev//8252005/webrev.00/ \
> > > > <http://cr.openjdk.java.net/~iignatyev//8252005/webrev.00/>
> > > > > 0 lines changed: 0 ins; 0 del; 0 mod;
> > > > Hi all,
> > > >
> > > > could you please review this trivial (and apparently empty) patch which sets \
> > > > allowSmartActionArgs to false only in subdirectories of vmTestbase which \
> > > > currently use PropertyResolvingWrapper?
> > > > (it's hard to tell from webrev or patch, but \
> > > > test/hotspot/jtreg/vmTestbase/TEST.properties is effectively removed)
> > > > webrev: http://cr.openjdk.java.net/~iignatyev//8252005/webrev.00/ \
> > > > <http://cr.openjdk.java.net/~iignatyev//8252005/webrev.00/>
> > > > JBS: https://bugs.openjdk.java.net/browse/JDK-8252005 \
> > > > <https://bugs.openjdk.java.net/browse/JDK-8252005>
> > > > Thanks,
> > > > -- Igor
> > > >
> > > >
> > >
> >
>
[Attachment #3 (unknown)]
<html><head><meta http-equiv="Content-Type" content="text/html; \
charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: \
space; line-break: after-white-space;" class="">thanks Serguei, pushed.<div \
class=""><div class=""><br class=""></div><div class="">-- Igor<br class=""><div><br \
class=""><blockquote type="cite" class=""><div class="">On Aug 20, 2020, at 10:55 AM, \
<a href="mailto:serguei.spitsyn@oracle.com" class="">serguei.spitsyn@oracle.com</a> \
wrote:</div><br class="Apple-interchange-newline"><div class="">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" class="">
<div class="">
<div class="moz-cite-prefix">Hi Igor,<br class="">
<br class="">
Still looks good to me.<br class="">
The webrev is veeeeery slow.<br class="">
<br class="">
Thanks,<br class="">
Serguei<br class="">
<br class="">
<br class="">
On 8/20/20 10:16, Igor Ignatyev wrote:<br class="">
</div>
<blockquote type="cite" \
cite="mid:C5209174-60CD-416C-80BE-7C5BC1C53284@oracle.com" class="">Hi Serguei,
<div class=""><br class="">
</div>
<div class="">thanks for your review. I've decided to slightly
modify the patch and use the ids of subtasks in TEST.properties
files (instead of main bug id) in order to avoid possible
confusion in the future:</div>
<div class=""> - incremental: <a \
href="http://cr.openjdk.java.net/~iignatyev//8252005/webrev.0-1/index.html" class="" \
moz-do-not-send="true">http://cr.openjdk.java.net/~iignatyev//8252005/webrev.0-1/index.html</a></div>
<div class=""> - whole: <a \
href="http://cr.openjdk.java.net/~iignatyev//8252005/webrev.01/index.html" class="" \
moz-do-not-send="true">http://cr.openjdk.java.net/~iignatyev//8252005/webrev.01/index.html</a></div>
<div class=""><br class="">
</div>
<div class="">could you please re-review it?</div>
<div class=""><br class="">
</div>
<div class="">Thanks,</div>
<div class="">-- Igor<br class="">
<div class=""><br class="">
<blockquote type="cite" class="">
<div class="">On Aug 19, 2020, at 4:22 PM, <a \
href="mailto:serguei.spitsyn@oracle.com" class="" \
moz-do-not-send="true">serguei.spitsyn@oracle.com</a> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="">Hi Igor,<br class="">
<br class="">
This looks reasonable.<br class="">
<br class="">
Thanks,<br class="">
Serguei<br class="">
<br class="">
<br class="">
On 8/18/20 16:42, Igor Ignatyev wrote:<br class="">
<blockquote type="cite" class=""><a \
href="http://cr.openjdk.java.net/~iignatyev//8252005/webrev.00/" class="" \
moz-do-not-send="true">http://cr.openjdk.java.net/~iignatyev//8252005/webrev.00/</a><br \
class=""> <blockquote type="cite" class="">0 lines changed: 0
ins; 0 del; 0 mod;<br class="">
</blockquote>
Hi all,<br class="">
<br class="">
could you please review this trivial (and apparently
empty) patch which sets allowSmartActionArgs to false
only in subdirectories of vmTestbase which currently
use PropertyResolvingWrapper?<br class="">
<br class="">
(it's hard to tell from webrev or patch, but
test/hotspot/jtreg/vmTestbase/TEST.properties is
effectively removed)<br class="">
<br class="">
webrev:
<a class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/~iignatyev//8252005/webrev.00/">http://cr.openjdk.java.net/~iignatyev//8252005/webrev.00/</a><br \
class=""> JBS: <a class="moz-txt-link-freetext" \
href="https://bugs.openjdk.java.net/browse/JDK-8252005">https://bugs.openjdk.java.net/browse/JDK-8252005</a><br \
class=""> <br class="">
Thanks,<br class="">
-- Igor<br class="">
<br class="">
<br class="">
</blockquote>
<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</blockquote>
<br class="">
</div>
</div></blockquote></div><br class=""></div></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic