[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8251835: 8251374 breaks jmap -dump:all(Internet mail)
From:       linzang(臧琳) <linzang () tencent ! com>
Date:       2020-08-14 22:57:03
Message-ID: 57A5EE89-AA63-4AC1-9D7F-B3276FF28F71 () tencent ! com
[Download RAW message or body]

Dear All,
         Sorry for making incomplete patch. And thanks for help fixing it.

BRs,
Lin

> On Aug 15, 2020, at 6:04 AM, "serguei.spitsyn@oracle.com" \
> <serguei.spitsyn@oracle.com> wrote: 
> Hi Stefan and Paul,
> 
> Thank you for taking care and fixing this regression!
> 
> It seems, the fix from Paul is more complete and is better to push after testing.
> It looks good to me.
> 
> Unfortunately, there is very limited test coverage for this.
> 
> Thanks,
> Serguei
> 
> 
> > On 8/14/20 09:47, Stefan Karlsson wrote:
> > > On 2020-08-14 18:39, Hohensee, Paul wrote:
> > > Makes sense to me to do a followup. I've filed \
> > > https://bugs.openjdk.java.net/browse/JDK-8251848.
> > 
> > Great.
> > 
> > > 
> > > I ran TEST="test/jdk/sun/tools/jmap/BasicJMapTest.java" \
> > > JTREG="JAVA_OPTIONS=-XX:+UseParallelGC -XX:ParallelGCThreads=100" successfully, \
> > > including your patch for 8251570. 
> > > This 8251835 patch looks good to me.
> > 
> > Thanks!
> > 
> > StefanK
> > 
> > > 
> > > Thanks,
> > > Paul
> > > 
> > > On 8/14/20, 7:49 AM, "Stefan Karlsson" <stefan.karlsson@oracle.com> wrote:
> > > 
> > > Hi all,
> > > 
> > > Please review this patch to fix a recently introduced jmap bug.
> > > 
> > > https://cr.openjdk.java.net/~stefank/8251835/webrev.01/
> > > https://bugs.openjdk.java.net/browse/JDK-8251835
> > > 
> > > I added the same kind of checks that we have in histo.
> > > 
> > > Testing:
> > > - Tested locally with the failing test
> > > - Tier1-tier5 on Linux x64
> > > 
> > > Paul posted a slightly more elaborate fix that makes dump more akin to
> > > histo:
> > > http://cr.openjdk.java.net/~phh/8251835/webrev.00/
> > > 
> > > I don't know the testing status of that patch. If this needs to be fixed
> > > ASAP, I propose my fix, and then add the rest of Pauls bits as a
> > > follow-up RFE. If we have time to run Paul's patch through testing, then
> > > I'm fine with that as well.
> > > 
> > > Thanks,
> > > StefanK
> > > 
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]