[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR (S) 8249822: SymbolPropertyTable creates an extra OopHandle per entry
From:       coleen.phillimore () oracle ! com
Date:       2020-07-24 11:44:17
Message-ID: c523aee0-7221-126a-430e-568450af8538 () oracle ! com
[Download RAW message or body]



On 7/24/20 1:41 AM, David Holmes wrote:
> On 23/07/2020 6:55 am, coleen.phillimore@oracle.com wrote:
>> Summary: Add an assert to OopHandle assigment operator to catch 
>> leaking OopHandles, and fix code accordingly.
>>
>> There are some jvmtiRedefineClasses.cpp changes here - basically, I 
>> moved the RedefineVerifyMark and comments into 
>> jvmtiRedefineClasses.cpp because I needed a Handle.
>>
>> Ran tier1-6 tests and tier1 on all Oracle platforms.
>>
>> open webrev at 
>> http://cr.openjdk.java.net/~coleenp/2020/8249822.01/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8249822
>
> This all seems okay. A couple of minor nits
>
> src/hotspot/share/oops/klass.cpp
>
> + void Klass::replace_java_mirror(oop mirror) { 
> _java_mirror.replace(mirror); }
>
> Writing this all in one line is inconsistent with surrounding style.

I was going to fix the java_mirror_no_keepalive() to match this style, 
but I've fixed this one instead.
>
> ---
>
> 1226 //  a) A reference to the class being redefined (_the_class) and a
> 1230 //   b) The _java_mirror field from _the_class is copied to the
>
> There's an extra space before b) on line 1230.

Wow. fixed.
Thanks for reviewing this!
Coleen

>
> Thanks,
> David
> -----
>
>
>> Thanks,
>> Coleen

[prev in list] [next in list] [prev in thread] [next in thread]