[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(XS): 8245913: JDI and JDWP ThreadReference::stop should only allow ThreadDeath
From:       "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date:       2020-05-29 22:09:45
Message-ID: 22cc3912-f0ee-770b-c4a3-8fc24c180443 () oracle ! com
[Download RAW message or body]

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">Hi David and reviewers,<br>
      <br>
      I've updated the webrev and CSR according to agreement with David
      to add<br>
      new error code to the JDWP ThreadReference::Stop command and new
      exception<br>
      to the JDI ThreadReference::stop method.<br>
      Also, I've updated one of the nsk.jdi tests to provide a necessary
      test coverage.<br>
      <br>
      Thanks,<br>
      Serguei<br>
      <br>
      On 5/26/20 22:58, <a class="moz-txt-link-abbreviated" \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a> wrote:<br>  \
</div>  <blockquote type="cite"
      cite="mid:c310c1f4-eb68-0471-a2ee-db8d33ca756c@oracle.com">
      Please, review a fix for:<br>
        <a class="moz-txt-link-freetext"
        href="https://bugs.openjdk.java.net/browse/JDK-8245913"
        moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8245913</a><br>
  <br>
      CSR draft (one CSR reviewer is needed before finalizing it):<br>
        <a class="moz-txt-link-freetext"
        href="https://bugs.openjdk.java.net/browse/JDK-8245923"
        moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8245923</a><br>
  <br>
      Webrev:<br>
        <a
href="http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-stop-thread.1/src/"
        title="Follow link" \
moz-do-not-send="true">http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-stop-thread.1/src/</a><br>
  <br>
      <br>
      Updated JDI ThreadReference:stop method spec: <br>
        <a
href="http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-stop-thread.1/docs/api/jdk.jdi/com/sun/jdi/ThreadReference.html#stop(com.sun.jdi.ObjectReference"
  title="Follow link" \
moz-do-not-send="true">http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-stop-thr \
ead.1/docs/api/jdk.jdi/com/sun/jdi/ThreadReference.html#stop(com.sun.jdi.ObjectReference</a>)<br>
  <br>
      <br>
      Updated JDWP ThreadReference:Stop command spec: <br>
        <a
href="http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-stop-thread.1/docs/specs/jdwp/jdwp-protocol.html#JDWP_ThreadReference_Stop"
  title="Follow link" \
moz-do-not-send="true">http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-stop-thread.1/docs/specs/jdwp/jdwp-protocol.html#JDWP_ThreadReference_Stop</a><br>
  <br>
      <br>
      Summary:<br>
        The RFR+CSR for JVMTI StopThread has been posted to the
      serviceability-dev mailing list.<br>
        This is a JPDA (JDI+JDWP) related spec update.<br>
        One question is if it is okay to refer to the ThreadDeath as an
      Exception while, in fact, it is an Error.<br>
        This update follows the initial JVM TI StopThread spec
      terminology.<br>
      <br>
      Testing: <br>
        Built docs and checked the doc has been generated as expected. <br>
        Will run the JDI/JDWP tests locally. <br>
        Will submit hs-tiers1-5 to make sure there are no regressions in
      the JDI/JDWP tests. <br>
      <br>
      Thanks, <br>
      Serguei <br>
    </blockquote>
    <br>
  </body>
</html>


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic