[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR(S): 8244668: Remove SA's javascript support
From: sundararajan.athijegannathan () oracle ! com
Date: 2020-05-28 4:45:15
Message-ID: 2ab26b85-d287-d27e-27e5-dcab624f8fd3 () oracle ! com
[Download RAW message or body]
Hi Chris,
Yes.
There are bugs with the label "nashorn_removal" for uses of nashorn.
Many scripts are needed for now (till the respective test or make file
use etc. are "ported" to do something else. For eg. make use of .js
falls back to bootjdk for now).
Thanks
-Sundar
On 28/05/20 9:40 am, Chris Plummer wrote:
> Hi Sundar,
>
> make, test, doc, and bin all have .js files. I was counting them in
> them also. 36 total files (not 36 directories).
>
> thanks,
>
> Chris
>
> On 5/27/20 8:12 PM, sundararajan.athijegannathan@oracle.com wrote:
>>
>> Hi Chris,
>>
>> Note that not all .js files are related to nashorn!
>>
>> * The one in java.scripting module is init.js file used by jrunscript
>> tool. The jrunscript is javax.script based scripting language
>> independent shell tool. It uses init.js script if the underlying
>> language engine happens to be 'javascript'. This tool still exists
>> and can use js engine if user drops suitable js engine jar in
>> classpath/modulepath.
>>
>> * The ones in jdk.javadoc are used in the browser (jquery,
>> search.js). There is a script to test javadoc's search feature. The
>> test looks for js engine before using the test. Developer can drop
>> another js engine and run the test.
>>
>> PS. "find . -name *.java" found only 10 .js paths in "jdk/src"
>> directory.36 directories?
>>
>> Thanks
>> -Sundar
>>
>> On 27/05/20 10:08 pm, Chris Plummer wrote:
>>> Hi Serguei,
>>>
>>> Possibly those should be deleted, but not as part of the removal of
>>> JS support from SA. They are for .js files in src/java.scripting,
>>> src/jdk.javadoc, and src/jdk.dev. There are no longer any .js files
>>> in src/jdk.dev, but there are in the other two directories. There
>>> are bunch more in other directories not listed, 36 in total. I'm
>>> guessing that some should have been removed when Nashorn was
>>> removed. Maybe Sundar can comment on this.
>>>
>>> thanks,
>>>
>>> Chris
>>>
>>> On 5/27/20 1:56 AM, serguei.spitsyn@oracle.com wrote:
>>>> Hi Chris,
>>>>
>>>> A couple of questions.
>>>>
>>>> http://cr.openjdk.java.net/~cjplummer/8244668/webrev.00/make/CompileJavaModules.gmk.udiff.html
>>>> -jdk.hotspot.agent_COPY += .gif .png sa.js .properties
>>>> +jdk.hotspot.agent_COPY += .gif .png .properties
>>>> There are more occurrences of the .js in that file:
>>>> 215 java.scripting_COPY += .js
>>>> 346 jdk.javadoc_COPY += .xml .css .js .png
>>>> 416 jdk.dev_COPY += .js oqlhelp.html .txt
>>>> Should all these be deleted?
>>>>
>>>> Otherwise, looks good.
>>>> No need in another webrev.
>>>>
>>>> Thanks,
>>>> Serguei
>>>>
>>>>
>>>> On 5/26/20 19:42, sundararajan.athijegannathan@oracle.com wrote:
>>>>> Looks good to me.
>>>>>
>>>>> -Sundar
>>>>>
>>>>> On 27/05/20 5:01 am, Chris Plummer wrote:
>>>>>> Hello,
>>>>>>
>>>>>> Please review the following changes to fully remove javascript
>>>>>> support from SA. It's been non-functional since JDK 9 and there
>>>>>> are no plans to support it anymore.
>>>>>>
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8244668
>>>>>> http://cr.openjdk.java.net/~cjplummer/8244668/webrev.00/index.html
>>>>>>
>>>>>> If anyone thinks a CSR is needed for this, please let me know.
>>>>>> There's no spec involved. The support was always pretty ad hoc,
>>>>>> with some supporting documentation in the source tree in
>>>>>> jsdb.html [1], but which doesn't appear itself to have ever been
>>>>>> released.
>>>>>>
>>>>>> There was one menu item in the hsdb GUI that used javascript (and
>>>>>> as a result caused an exception). I was having a little trouble
>>>>>> deciphering what it actually does, but it appears to allow you to
>>>>>> write some javascript to produce (and filter) a list of objects,
>>>>>> and then display the list of objects in a window where you could
>>>>>> inspect them further. Since there is no way to do something
>>>>>> similar in java without allowing the user to provide hsdb
>>>>>> extensions in the form of .class files (or support writing and
>>>>>> compiling java classes from within hsdb), I just removed the hsdb
>>>>>> feature by removing the menu item and supporting code.
>>>>>>
>>>>>> thanks,
>>>>>>
>>>>>> Chris
>>>>>>
>>>>>> [1]
>>>>>> https://hg.openjdk.java.net/jdk/jdk/raw-file/a7e42c260029/src/jdk.hotspot.agent/doc/jsdb.html
>>>>
>>>
>
[Attachment #3 (text/html)]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hi Chris,</p>
<p>Yes.<br>
</p>
<p>There are bugs with the label "nashorn_removal" for uses of
nashorn. Many scripts are needed for now (till the respective test
or make file use etc. are "ported" to do something else. For eg.
make use of .js falls back to bootjdk for now).</p>
<p>Thanks</p>
<p>-Sundar</p>
<div class="moz-cite-prefix">On 28/05/20 9:40 am, Chris Plummer
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:212ec11b-6373-a7be-ca65-5e4fe8b57c73@oracle.com">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<div class="moz-cite-prefix">Hi Sundar,<br>
<br>
make, test, doc, and bin all have .js files. I was counting them
in them also. 36 total files (not 36 directories).<br>
<br>
thanks,<br>
<br>
Chris<br>
<br>
On 5/27/20 8:12 PM, <a class="moz-txt-link-abbreviated"
href="mailto:sundararajan.athijegannathan@oracle.com"
moz-do-not-send="true">sundararajan.athijegannathan@oracle.com</a>
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:4bbba1a8-969f-71a3-52dd-11a488926678@oracle.com">
<meta http-equiv="Content-Type" content="text/html;
charset=UTF-8">
<p>Hi Chris,</p>
<p>Note that not all .js files are related to nashorn! <br>
</p>
<p>* The one in java.scripting module is init.js file used by
jrunscript tool. The jrunscript is javax.script based
scripting language independent shell tool. It uses init.js
script if the underlying language engine happens to be
'javascript'. This tool still exists and can use js engine if
user drops suitable js engine jar in classpath/modulepath.</p>
<p>* The ones in jdk.javadoc are used in the browser (jquery,
search.js). There is a script to test javadoc's search
feature. The test looks for js engine before using the test.
Developer can drop another js engine and run the test. <br>
</p>
<p>PS. "find . -name *.java" found only 10 .js paths in
"jdk/src" directory.36 directories?<br>
</p>
<div class="moz-cite-prefix">Thanks</div>
<div class="moz-cite-prefix">-Sundar<br>
</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">On 27/05/20 10:08 pm, Chris Plummer
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:13e9f5c1-313d-bd1e-1ae7-1ae4314a9df5@oracle.com">
<meta http-equiv="Content-Type" content="text/html;
charset=UTF-8">
<div class="moz-cite-prefix">Hi Serguei,<br>
<br>
Possibly those should be deleted, but not as part of the
removal of JS support from SA. They are for .js files in
src/java.scripting, src/jdk.javadoc, and src/jdk.dev. There
are no longer any .js files in src/jdk.dev, but there are in
the other two directories. There are bunch more in other
directories not listed, 36 in total. I'm guessing that some
should have been removed when Nashorn was removed. Maybe
Sundar can comment on this.<br>
<br>
thanks,<br>
<br>
Chris<br>
<br>
On 5/27/20 1:56 AM, <a class="moz-txt-link-abbreviated"
href="mailto:serguei.spitsyn@oracle.com"
moz-do-not-send="true">serguei.spitsyn@oracle.com</a>
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:5b805386-095f-d105-7ffb-2767e38c741f@oracle.com">
<meta http-equiv="Content-Type" content="text/html;
charset=UTF-8">
<div class="moz-cite-prefix">Hi Chris,<br>
<br>
A couple of questions.<br>
<br>
<pre><span class="removed"><a class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/~cjplummer/8244668/webrev.00/make/CompileJavaModules.gmk.udiff.html" \
moz-do-not-send="true">http://cr.openjdk.java.net/~cjplummer/8244668/webrev.00/make/CompileJavaModules.gmk.udiff.html</a>
-jdk.hotspot.agent_COPY += .gif .png sa.js .properties</span>
<span class="new">+jdk.hotspot.agent_COPY += .gif .png .properties</span></pre>
There are more occurrences of the .js in that file:<br>
<pre> 215 java.scripting_COPY += .js
346 jdk.javadoc_COPY += .xml .css .js .png
416 jdk.dev_COPY += .js oqlhelp.html .txt</pre>
Should all these be deleted?<br>
<br>
Otherwise, looks good.<br>
No need in another webrev.<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
On 5/26/20 19:42, <a class="moz-txt-link-abbreviated"
href="mailto:sundararajan.athijegannathan@oracle.com"
moz-do-not-send="true">sundararajan.athijegannathan@oracle.com</a>
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:2191a9f4-2a5b-d09f-8bf1-da517fdbf950@oracle.com">Looks
good to me. <br>
<br>
-Sundar <br>
<br>
On 27/05/20 5:01 am, Chris Plummer wrote: <br>
<blockquote type="cite">Hello, <br>
<br>
Please review the following changes to fully remove
javascript support from SA. It's been non-functional
since JDK 9 and there are no plans to support it
anymore. <br>
<br>
<a class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8244668"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8244668</a>
<br>
<a class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/~cjplummer/8244668/webrev.00/index.html"
moz-do-not-send="true">http://cr.openjdk.java.net/~cjplummer/8244668/webrev.00/index.html</a>
<br>
<br>
If anyone thinks a CSR is needed for this, please let me
know. There's no spec involved. The support was always
pretty ad hoc, with some supporting documentation in the
source tree in jsdb.html [1], but which doesn't appear
itself to have ever been released. <br>
<br>
There was one menu item in the hsdb GUI that used
javascript (and as a result caused an exception). I was
having a little trouble deciphering what it actually
does, but it appears to allow you to write some
javascript to produce (and filter) a list of objects,
and then display the list of objects in a window where
you could inspect them further. Since there is no way to
do something similar in java without allowing the user
to provide hsdb extensions in the form of .class files
(or support writing and compiling java classes from
within hsdb), I just removed the hsdb feature by
removing the menu item and supporting code. <br>
<br>
thanks, <br>
<br>
Chris <br>
<br>
[1] <a class="moz-txt-link-freetext"
href="https://hg.openjdk.java.net/jdk/jdk/raw-file/a7e42c260029/src/jdk.hotspot.agent/doc/jsdb.html"
moz-do-not-send="true">https://hg.openjdk.java.net/jdk/jdk/raw-file/a7e42c260029/src/jdk.hotspot.agent/doc/jsdb.html</a><br>
</blockquote>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
</blockquote>
<br>
</blockquote>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic