[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: RFR (S): 8245129: Enhance jstat gc option output and tests
From: "Hohensee, Paul" <hohensee () amazon ! com>
Date: 2020-05-18 15:23:55
Message-ID: 79438EAF-531A-488F-BED7-A619C3E227D5 () amazon ! com
[Download RAW message or body]
[Attachment #2 (text/plain)]
Please review an enhancement to the jstat gc option output to make the columns wider \
(for up to a 2TB heap) so one can read the output without going cross-eyed.
Bug: https://bugs.openjdk.java.net/browse/JDK-8245129
Webrev: http://cr.openjdk.java.net/~phh/8245129/webrev.00/
I added tests using ParallelGC since the output can differ for non-G1 collectors. \
Successfully ran the test/hotspot/jtreg/serviceability/tmtools/jstat and \
test/jdk/sun/tools/jstat tests. A submit repo run had one failure
runtime/MemberName/MemberNameLeak.java
tier1
macosx-x64-debug
but rerunning it on my laptop succeeded, and there's no connection between this test \
and my patch.
Thanks,
Paul
[Attachment #3 (text/html)]
<html xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"> <head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Menlo;
panose-1:2 11 6 9 3 8 4 2 2 4;}
@font-face
{font-family:-webkit-standard;
panose-1:2 11 6 4 2 2 2 2 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
p.p1, li.p1, div.p1
{mso-style-name:p1;
margin:0in;
margin-bottom:.0001pt;
font-size:8.5pt;
font-family:Menlo;
color:black;}
span.s1
{mso-style-name:s1;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:12.0pt;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt">Please review an enhancement to \
the jstat gc option output to make the columns wider (for up to a 2TB heap) so one \
can read the output without going cross-eyed.<o:p></o:p></span></p> <p \
class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p> <p \
class="MsoNormal"><span style="font-size:11.0pt">Bug: <a \
href="https://bugs.openjdk.java.net/browse/JDK-8245129"> \
https://bugs.openjdk.java.net/browse/JDK-8245129</a><o:p></o:p></span></p> <p \
class="MsoNormal"><span style="font-size:11.0pt">Webrev: <a \
href="http://cr.openjdk.java.net/~phh/8245129/webrev.00/"> \
http://cr.openjdk.java.net/~phh/8245129/webrev.00/</a><o:p></o:p></span></p> <p \
class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p> <p \
class="p1"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">I \
added tests using ParallelGC since the output can differ for non-G1 collectors. \
Successfully ran the </span><span class="s1"><span \
style="font-size:11.0pt;font-family:"Calibri",sans-serif">test/hotspot/jtreg/serviceability/tmtools/jstat \
and test/jdk/sun/tools/jstat</span></span><span \
style="font-size:11.0pt;font-family:"Calibri",sans-serif"> tests. A submit \
repo run had one failure<o:p></o:p></span></p> <p class="p1"><span \
style="font-size:11.0pt;font-family:"Calibri",sans-serif"><o:p> </o:p></span></p>
<table class="MsoNormalTable" border="1" cellpadding="0">
<tbody>
<tr>
<td style="padding:.75pt .75pt .75pt .75pt">
<p class="MsoNormal"><span \
style="font-size:11.0pt;font-family:"-webkit-standard",serif">runtime/MemberName/MemberNameLeak.java<o:p></o:p></span></p>
</td>
<td style="padding:.75pt .75pt .75pt .75pt">
<p class="MsoNormal"><span \
style="font-size:11.0pt;font-family:"-webkit-standard",serif">tier1<o:p></o:p></span></p>
</td>
<td style="padding:.75pt .75pt .75pt .75pt">
<p class="MsoNormal"><span \
style="font-size:11.0pt;font-family:"-webkit-standard",serif">macosx-x64-debug<o:p></o:p></span></p>
</td>
</tr>
</tbody>
</table>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="p1"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">but \
rerunning it on my laptop succeeded, and there's no connection between this test and \
my patch.<o:p></o:p></span></p> <p class="p1"><span \
style="font-size:11.0pt;font-family:"Calibri",sans-serif"><o:p> </o:p></span></p>
<p class="p1"><span \
style="font-size:11.0pt;font-family:"Calibri",sans-serif">Thanks,<o:p></o:p></span></p>
<p class="p1"><span \
style="font-size:11.0pt;font-family:"Calibri",sans-serif">Paul<o:p></o:p></span></p>
<p class="p1"><span \
style="font-size:11.0pt;font-family:"Calibri",sans-serif"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic