[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: trivial RFR(XS): 8243941: build issue introduced with the push of 8242237
From: "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date: 2020-04-28 4:47:38
Message-ID: a67e65d7-dc82-4b71-edfb-fc4d1cf88565 () oracle ! com
[Download RAW message or body]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="moz-cite-prefix">Pushed.<br>
Sorry for the inconvenience.<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
On 4/27/20 20:55, Igor Ignatyev wrote:<br>
</div>
<blockquote type="cite"
cite="mid:0439B25C-731F-45AB-9CBB-712D2D4F923E@oracle.com">sure,
and thank you, Serguei, for handling this so promptly!
<div class=""><br class="">
<div class="">
<div class="">-- Igor<br class="">
<div><br class="">
<blockquote type="cite" class="">
<div class="">On Apr 27, 2020, at 8:54 PM, <a
href="mailto:serguei.spitsyn@oracle.com" class=""
moz-do-not-send="true">serguei.spitsyn@oracle.com</a>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="">
<div class="moz-cite-prefix">Thanks, Igor!<br
class="">
Will push it after build-tier1 job is completed.<br
class="">
<br class="">
Thanks,<br class="">
Serguei<br class="">
<br class="">
On 4/27/20 20:53, Igor Ignatyev wrote:<br class="">
</div>
<blockquote type="cite"
cite="mid:E1F2DA95-BB64-4888-B1D7-74712617CDB7@oracle.com"
class="">Hi Serguei,
<div class=""><br class="">
</div>
<div class="">LGTM,</div>
<div class=""><br class="">
</div>
<div class="">-- Igor<br class="">
<div class=""><br class="">
<blockquote type="cite" class="">
<div class="">On Apr 27, 2020, at 8:52 PM, <a
href="mailto:serguei.spitsyn@oracle.com"
class="" moz-do-not-send="true">serguei.spitsyn@oracle.com</a>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class=""> Please, review small patch
to fix the build regression caused by
fix of 8242237.<br class="">
<br class="">
Patch:<br class="">
<br class="">
diff --git
a/test/hotspot/jtreg/serviceability/jvmti/HiddenClass/libHiddenClassSigTest.cpp
b/test/hotspot/jtreg/serviceability/jvmti/HiddenClass/libHiddenClassSigTest.cpp<br
class="">
---
a/test/hotspot/jtreg/serviceability/jvmti/HiddenClass/libHiddenClassSigTest.cpp<br
class="">
+++
b/test/hotspot/jtreg/serviceability/jvmti/HiddenClass/libHiddenClassSigTest.cpp<br
class="">
@@ -242,7 +242,7 @@<br class="">
<br class="">
/* Process a CLASS_LOAD or
aClassPrepare event. */<br class="">
static void
process_class_event(jvmtiEnv* jvmti,
JNIEnv* jni, jclass klass,<br class="">
- int*
event_count_ptr, const char* event_name)
{<br class="">
+ jint*
event_count_ptr, const char* event_name)
{<br class="">
char* sig = NULL;<br class="">
char* gsig = NULL;<br class="">
jvmtiError err;<br class="">
<br class="">
<br class="">
Summary:<br class="">
Windows Compiler reports errors when a
parameter is declared as 'int*' but
jint* is actually used in the calls:<br
class="">
<br class="">
./open/test/hotspot/jtreg/serviceability/jvmti/HiddenClass/libHiddenClassSigTest.cpp(271):
error C2664: 'void
process_class_event(jvmtiEnv *,JNIEnv
*,jclass,int *,const char *)': cannot
convert argument 4 from 'jint *' to 'int
*' <br class="">
./open/test/hotspot/jtreg/serviceability/jvmti/HiddenClass/libHiddenClassSigTest.cpp(271):
note: Types pointed to are unrelated;
conversion requires reinterpret_cast,
C-style cast or function-style cast<br
class="">
<br class="">
<br class="">
Testing:<br class="">
A mach5 job build-tier1 submitted.<br
class="">
<br class="">
Thanks,<br class="">
serguei<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</blockquote>
<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</div>
</div>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic