[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR (S): 8242237: Improve JVM TI HiddenClasses tests
From:       "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date:       2020-04-27 21:26:53
Message-ID: 1e2ce201-abd2-3cba-30fd-8667025de6ea () oracle ! com
[Download RAW message or body]

Thanks a lot, Alex!
Serguei


On 4/27/20 14:24, Alex Menkov wrote:
> Hi Serguei,
>
> LGTM++
>
> --alex
>
> On 04/24/2020 15:20, serguei.spitsyn@oracle.com wrote:
>> Hi Leonid,
>>
>> Thank you for review and suggestion.
>> Will fix it.
>>
>> Thanks,
>> Serguei
>>
>>
>> On 4/24/20 15:11, Leonid Mesnik wrote:
>>> Looks good.
>>>
>>> The small nit (optional). New function
>>>   287 static void JNICALL
>>>   288 ClassPrepare(jvmtiEnv* jvmti, JNIEnv* jni, jthread thread, 
>>> jclass klass) {
>>>
>>> is very similar to ClassLoad, and verification of signature might be 
>>> moved into common function.
>>>
>>> Leonid
>>>
>>>> On Apr 24, 2020, at 11:31 AM, serguei.spitsyn@oracle.com 
>>>> <mailto:serguei.spitsyn@oracle.com> wrote:
>>>>
>>>> Please, review a fix for the sub-task:
>>>> https://bugs.openjdk.java.net/browse/JDK-8242237
>>>>
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jvmti-hidden-test-update.1/ 
>>>>
>>>>
>>>> Summary:
>>>>   The test update includes:
>>>>    - interface and method renaming: Test => HCInterf, test() => 
>>>> hcMethod()
>>>>    - readClassFile replaced with Files.readAllBytes
>>>>    - added ClassPrepare event
>>>>    - removed unneeded capability can_get_source_file_name
>>>>    - added more comments
>>>>
>>>> Testing:
>>>>   Tested locally on Linux, mach5 test run is in progress:
>>>> https://mach5.us.oracle.com/mdash/jobs/sspitsyn-HiddenClass-jvmti-test-20200424-1829-10485216 
>>>>
>>>>
>>>> Thanks,
>>>> Serguei
>>>>
>>>
>>

[prev in list] [next in list] [prev in thread] [next in thread]