[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR (S) 8239055: Wrong implementation of VMState.hasListener
From:       Poonam Parhar <poonam.bajaj () oracle ! com>
Date:       2020-02-20 2:22:34
Message-ID: ede7176c-413b-91cb-add2-77b62fc49d86 () oracle ! com
[Download RAW message or body]

Hello Fairoz,

The change looks good to me as well.

Thanks,
Poonam

On 2/18/20 12:26 PM, serguei.spitsyn@oracle.com wrote:
> Hi Fairoz,
>
> Looks good.
>
> Thanks,
> Serguei
>
>
> On 2/13/20 9:13 PM, Fairoz Matte wrote:
>>
>> Hi,
>>
>> Please review a tiny change to correct the VMState.hasListener 
>> implementation.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8239055
>>
>> Webrev: http://cr.openjdk.java.net/~fmatte/8239055/webrev.00/
>>
>> Thanks,
>>
>> Fairoz
>>
>


[Attachment #3 (text/html)]

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    Hello Fairoz,<br>
    <br>
    The change looks good to me as well.<br>
    <br>
    Thanks,<br>
    Poonam<br>
    <br>
    <div class="moz-cite-prefix">On 2/18/20 12:26 PM,
      <a class="moz-txt-link-abbreviated" \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a> wrote:<br>  \
</div>  <blockquote type="cite"
      cite="mid:874b118b-c3c5-ce16-c62a-0d96fd505f56@oracle.com">
      <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
      Hi Fairoz,<br>
      <br>
      Looks good.<br>
      <br>
      Thanks,<br>
      Serguei<br>
      <br>
      <br>
      <div class="moz-cite-prefix">On 2/13/20 9:13 PM, Fairoz Matte
        wrote:<br>
      </div>
      <blockquote type="cite"
        cite="mid:988ac692-444a-4025-99c5-421d4c554f3b@default">
        <meta http-equiv="Content-Type" content="text/html;
          charset=UTF-8">
        <meta name="Generator" content="Microsoft Word 15 (filtered
          medium)">
        <style><!--
/* Font Definitions */
@font-face
	{font-family:"Cambria Math";
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0in;
	margin-bottom:.0001pt;
	font-size:11.0pt;
	font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:#0563C1;
	text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
	{mso-style-priority:99;
	color:#954F72;
	text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
	{mso-style-priority:99;
	mso-style-link:"Plain Text Char";
	margin:0in;
	margin-bottom:.0001pt;
	font-size:11.0pt;
	font-family:"Calibri",sans-serif;}
span.EmailStyle17
	{mso-style-type:personal-compose;
	font-family:"Calibri",sans-serif;
	color:windowtext;}
span.PlainTextChar
	{mso-style-name:"Plain Text Char";
	mso-style-priority:99;
	mso-style-link:"Plain Text";
	font-family:"Calibri",sans-serif;}
.MsoChpDefault
	{mso-style-type:export-only;
	font-family:"Calibri",sans-serif;}
@page WordSection1
	{size:8.5in 11.0in;
	margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
	{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
        <div class="WordSection1">
          <p class="MsoPlainText">Hi,<o:p></o:p></p>
          <p class="MsoPlainText"><o:p> </o:p></p>
          <p class="MsoPlainText">Please review a tiny change to correct
            the VMState.hasListener implementation.<o:p></o:p></p>
          <p class="MsoPlainText"><o:p> </o:p></p>
          <p class="MsoPlainText">JBS: <a
              href="https://bugs.openjdk.java.net/browse/JDK-8239055"
              moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8239055</a>
  <o:p></o:p></p>
          <p class="MsoPlainText">Webrev: <a
              href="http://cr.openjdk.java.net/~fmatte/8239055/webrev.00/"
              moz-do-not-send="true">http://cr.openjdk.java.net/~fmatte/8239055/webrev.00/</a><o:p></o:p></p>
  <p class="MsoPlainText"><o:p> </o:p></p>
          <p class="MsoPlainText">Thanks,<o:p></o:p></p>
          <p class="MsoPlainText">Fairoz<o:p></o:p></p>
          <p class="MsoNormal"><o:p> </o:p></p>
        </div>
      </blockquote>
      <br>
    </blockquote>
    <br>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic