[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR [XS]: 8238602: remove obsolete functions from libinstrument/FileSystemSupport_md.c
From: serguei.spitsyn () oracle ! com
Date: 2020-02-11 19:19:55
Message-ID: 5eba2808-811b-15d4-0c81-05051f7c3c7e () oracle ! com
[Download RAW message or body]
Hi Matthias,
It looks good.
Thanks,
Serguei
On 2/6/20 8:06 AM, Baesken, Matthias wrote:
>
> Hello,
>
> the link time section gc (see
> https://bugs.openjdk.java.net/browse/JDK-8236714 , on linux s390x it
> prints the removed sections) showed some obsolete / unused functions
> in FileSystemSupport_md.c :
>
> ld: Removing unused section '.text.pathSeparator' in file
> '/nightly/output-jdk-dev/support/native/java.instrument/libinstrument/FileSystemSupport_md.o'
>
> ld: Removing unused section '.text.filenameStrcmp' in file
> '/nightly/output-jdk-dev/support/native/java.instrument/libinstrument/FileSystemSupport_md.o'
>
> They can be cleaned up.
>
> Bug/webrev :
>
> https://bugs.openjdk.java.net/browse/JDK-8238602
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8238602.0/
>
> Thanks, Matthias
>
[Attachment #3 (text/html)]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
Hi Matthias,<br>
<br>
It looks good.<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<div class="moz-cite-prefix">On 2/6/20 8:06 AM, Baesken, Matthias
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:AM0PR02MB4227546EC8AF7E939DA95152931D0@AM0PR02MB4227.eurprd02.prod.outlook.com">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US">Hello, <o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#172B4D;background:white"
lang="EN-US"> the link time section gc (see </span><a
href="https://bugs.openjdk.java.net/browse/JDK-8236714"
title="Follow link" moz-do-not-send="true"><span
style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#0052CC;background:white;text-decoration:none"
lang="EN-US">https://bugs.openjdk.java.net/browse/JDK-8236714</span></a><span
style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#172B4D;background:white"
lang="EN-US"> , on linux s390x it prints the removed
sections) showed some obsolete / unused functions in
FileSystemSupport_md.c :<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#172B4D;background:white"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#172B4D;background:white"
lang="EN-US">ld: Removing unused section
'.text.pathSeparator' in file
'/nightly/output-jdk-dev/support/native/java.instrument/libinstrument/FileSystemSupport_md.o'<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#172B4D;background:white"
lang="EN-US">ld: Removing unused section
'.text.filenameStrcmp' in file
'/nightly/output-jdk-dev/support/native/java.instrument/libinstrument/FileSystemSupport_md.o'<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#172B4D;background:white"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#172B4D;background:white"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#172B4D;background:white"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#172B4D;background:white"
lang="EN-US">They can be cleaned up.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal">Bug/webrev :<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><a
href="https://bugs.openjdk.java.net/browse/JDK-8238602"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8238602</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><a
href="http://cr.openjdk.java.net/~mbaesken/webrevs/8238602.0/"
moz-do-not-send="true">http://cr.openjdk.java.net/~mbaesken/webrevs/8238602.0/</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks, Matthias<o:p></o:p></p>
</div>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic