[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR (M) 8234510: Remove file seeking requirement for writing a heap dump
From:       Thomas_Stüfe <thomas.stuefe () gmail ! com>
Date:       2020-01-23 8:36:48
Message-ID: CAA-vtUwee=i=gyzPxZeVeKtvuybyL7cd20eZwdnh=oNZDH4GYw () mail ! gmail ! com
[Download RAW message or body]

Hi Ralf,

belated, but looks good to me.

Thanks, Thomas

On Mon, Dec 16, 2019 at 1:28 PM Schmelter, Ralf <ralf.schmelter@sap.com>
wrote:

> I forgot to post the updated webrev:
> http://cr.openjdk.java.net/~rschmelter/webrevs/8234510/webrev.2/
>
> In addition to the changes requested by Thomas, I also renamed the entries
> in the heap dump segment from entries to sub-records, since that is what
> they are called in the comment describing the format.
>
> Best regards,
> Ralf
>
>

[Attachment #3 (text/html)]

<div dir="ltr">Hi Ralf,<div><br></div><div>belated, but looks good to me.  \
</div><div><br></div><div>Thanks, Thomas</div></div><br><div class="gmail_quote"><div \
dir="ltr" class="gmail_attr">On Mon, Dec 16, 2019 at 1:28 PM Schmelter, Ralf &lt;<a \
href="mailto:ralf.schmelter@sap.com">ralf.schmelter@sap.com</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I forgot to post the \
updated webrev:<br> <a \
href="http://cr.openjdk.java.net/~rschmelter/webrevs/8234510/webrev.2/" \
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~rschmelter/webrevs/8234510/webrev.2/</a><br>
 <br>
In addition to the changes requested by Thomas, I also renamed the entries in the \
heap dump segment from entries to sub-records, since that is what they are called in \
the comment describing the format.<br> <br>
Best regards,<br>
Ralf<br>
<br>
</blockquote></div>



[prev in list] [next in list] [prev in thread] [next in thread]