[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8213222: remove RMIConnectorServer.CREDENTIAL_TYPES
From:       Daniil Titov <daniil.x.titov () oracle ! com>
Date:       2020-01-14 21:05:10
Message-ID: B574863A-40BC-480D-919E-4EE65F05EC9F () oracle ! com
[Download RAW message or body]

Hi Alan and Daniel,

Thank you for reviewing this change and the CSR. I updated the release note 
as Daniel suggested.

Best regards,
Daniil


On 1/13/20, 7:36 AM, "Daniel Fuchs" <daniel.fuchs@oracle.com> wrote:

    Hi Daniil,
    
    Looks good to me as well. I wonder however if the release note
    should point to the replacement?
    Something like:
    
    The terminally deprecated constant 
    `javax.management.remote.rmi.RMIConnectorServer.CREDENTIAL_TYPE` has 
    been removed. A filter pattern can be specified instead using 
    `RMIConnectorServer.CREDENTIALS_FILTER_PATTERN`.
    
    best regards,
    
    -- daniel
    
    
    On 11/01/2020 04:52, Daniil Titov wrote:
    > Please review a change [1] that removes constant \
javax.management.remote.rmi.RMIConnectorServer.CREDENTIAL_TYPE.  > This constant \
represents the name of the attribute that specifies a list of class names acceptable \
to the RMIServer.newClient()  > remote method call. This constant was superseded by \
RMIConnectorServer.CREDENTIALS_FILTER_PATTERN and marked as  > deprecated for removal \
in JDK 10 [3].  > 
    > A new CRS [4]  and a release note sub-task [5]  were also created. Please \
review the CSR [4] as well.  > 
    > Text search over the repository didn't find any other usage of this constant. \
Tier1 - tier3 Mach5 tests succeeded.  > 
    > [1] Webrev:  http://cr.openjdk.java.net/~dtitov/8213222/webrev.01/
    > [2] Issue: https://bugs.openjdk.java.net/browse/JDK-8213222
    > [3] https://bugs.openjdk.java.net/browse/JDK-8191313
    > [4] CSR:  https://bugs.openjdk.java.net/browse/JDK-8236954
    > [5] Release Note sub-task: https://bugs.openjdk.java.net/browse/JDK-8236955
    > 
    > Thank you,
    > Daniil
    > 
    > 
    
    


[prev in list] [next in list] [prev in thread] [next in thread]