[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(S): 8169467: GetLocalInstance returns JVMTI_ERROR_TYPE_MISMATCH (rather than JVMTI_ERROR_INV
From:       "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date:       2019-11-22 10:10:14
Message-ID: 29de14f9-d278-5920-5be0-ffbf1c74e621 () oracle ! com
[Download RAW message or body]

Thank you, Chris!
Serguei

On 11/20/19 18:22, Chris Plummer wrote:
> +1
>
> On 11/20/19 3:32 PM, Alex Menkov wrote:
>> Looks good.
>>
>> --alex
>>
>> On 11/19/2019 15:36, serguei.spitsyn@oracle.com wrote:
>>> Please, review a fix for:
>>>    https://bugs.openjdk.java.net/browse/JDK-8169467
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8169467-jvmti-local-instance.1/ 
>>>
>>>
>>> Summary:
>>>    The JVMTI GetLocalInstance function should return 
>>> JVMTI_ERROR_INVALID_SLOT for static method frames.
>>>    Instead, it returns the JVMTI_ERROR_TYPE_MISMATCH error.
>>>    The fix adds necessary checks into the implementation.
>>>
>>> Testing in progress:
>>>    - Locally on Linux-x64 with: vmTestbase_nsk_jvmti, 
>>> vmTestbase_nsk_jdi, jdk_jdi
>>>    - All mach5 hs-tier5
>>>
>>> Thanks,
>>> Serguei
>
>

[prev in list] [next in list] [prev in thread] [next in thread]