[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR: JDK-8215196: [Graal] vmTestbase/nsk/jvmti/PopFrame/popframe003/TestDescription.java fails w
From: "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date: 2019-11-11 11:17:33
Message-ID: 9b65ade5-4f37-bbb5-7a28-3ad82bc32d6e () oracle ! com
[Download RAW message or body]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Hi Alex,<br>
<br>
The fix itself looks Okay.<br>
Minor: replace in the comment: "<span class="new">compiler don't
drop" => </span><span class="new">"compiler doesn't drop".<br>
<br>
However, we still have to reach a consensus on how we treat this
issue (as Chris already commented).<br>
<br>
Thanks,<br>
Serguei<br>
<br>
</span><br>
On 11/8/19 15:22, Alex Menkov wrote:<br>
</div>
<blockquote type="cite"
cite="mid:dbcd93d3-5735-3cba-b6a5-6e2010e3809c@oracle.com">Hi all,
<br>
<br>
Please review the fix for
<br>
<a class="moz-txt-link-freetext" \
href="https://bugs.openjdk.java.net/browse/JDK-8215196">https://bugs.openjdk.java.net/browse/JDK-8215196</a>
<br>
webrev:
<br>
<a class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/~amenkov/jdk14/popframe_args/webrev/">http://cr.openjdk.java.net/~amenkov/jdk14/popframe_args/webrev/</a>
<br>
<br>
Currently PopFrame is disabled with JVMCI by [1], so for testing I
reverted [1] changes.
<br>
<br>
[1] <a class="moz-txt-link-freetext" \
href="https://bugs.openjdk.java.net/browse/JDK-8218025">https://bugs.openjdk.java.net/browse/JDK-8218025</a>
<br>
<br>
--alex
<br>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic