[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR (XS) 8233790: Forward output from heap dumper to jcmd/jmap
From:       "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date:       2019-11-11 10:33:40
Message-ID: 36e15875-98ac-559d-3d15-e7c5723d46c0 () oracle ! com
[Download RAW message or body]

Hi Ralf,

Okay, thanks!
Serguei

On 11/11/19 00:48, Schmelter, Ralf wrote:
> Hi Serguei,
>
> Thanks for the review. The only open question seems to be:
>
>> The dumper.dump() returns int value.
>> Returned value is not used anymore in the attachListener.cpp and diagnisticCommand.cpp.
>> Is it still used somewhere else or we can replace it with void?
> The jmm_DumpHeap0 method still uses the return code (and the error string) to throw an
> exception in case of an error.
>
> Best regards,
> Ralf

[prev in list] [next in list] [prev in thread] [next in thread]