[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(S): JDK-8231287: JMap should do a better job of reporting exception it catches
From:       Chris Plummer <chris.plummer () oracle ! com>
Date:       2019-09-27 23:54:42
Message-ID: 4064e799-85fc-51e9-894c-9a35f395c422 () oracle ! com
[Download RAW message or body]

Thanks for the quick reviews!

Chris

On 9/27/19 2:49 PM, Hohensee, Paul wrote:
> +1.
> 
> Paul
> 
> On 9/27/19, 2:06 PM, "serviceability-dev on behalf of \
> serguei.spitsyn@oracle.com" <serviceability-dev-bounces@openjdk.java.net on behalf \
> of serguei.spitsyn@oracle.com> wrote: 
> Hi Chris,
> 
> It looks good.
> 
> Thanks,
> Serguei
> 
> On 9/27/19 1:29 PM, Chris Plummer wrote:
> > Hello,
> > 
> > Please review the following:
> > 
> > https://bugs.openjdk.java.net/browse/JDK-8231287
> > http://cr.openjdk.java.net/~cjplummer/8231287/webrev.00
> > 
> > Basically no longer have jmap consume and hide exceptions that are
> > thrown, and have all tools catch and print any exception that is
> > propagated to Tools.execute(). The CR contains more details.
> > 
> > Tested with the following:
> > 
> > > hotspot_serviceability
> > > jdk_svc
> > > vmTestbase_nsk_jdi
> > > vmTestbase_nsk_jvmti
> > > vmTestbase_nsk_jdwp
> > > vmTestbase_nsk_jdb
> > 
> > thanks,
> > 
> > Chris
> > 
> 
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]