[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: JDK-8199136: Dead code in src/jdk.jcmd/share/classes/sun/tools/common/ProcessArgumentMatcher.jav
From: Daniil Titov <daniil.x.titov () oracle ! com>
Date: 2019-09-25 4:46:31
Message-ID: 66A8280E-B4EB-40F6-98BC-DABF66EF2107 () oracle ! com
[Download RAW message or body]
Hi Evgeny,
The change looks good to me.
Thanks!
--Daniil
From: serviceability-dev <serviceability-dev-bounces@openjdk.java.net> on behalf of \
Evgeny Mandrikov <mandrikov@gmail.com>
Date: Tuesday, September 24, 2019 at 1:32 AM
To: David Holmes <david.holmes@oracle.com>
Cc: <serviceability-dev@openjdk.java.net>
Subject: Re: RFR: JDK-8199136: Dead code in \
src/jdk.jcmd/share/classes/sun/tools/common/ProcessArgumentMatcher.java
On Tue, Sep 24, 2019 at 8:15 AM David Holmes <david.holmes@oracle.com> wrote:
I just spotted this review request languishing in the mailing list.
The patch will need to be rebased against latest jdk sources, so please
do that. I'll see if I can drum up a second reviewer and get a sponsor.
Hi David,
No pb, here is rebased patch - http://cr.openjdk.java.net/~godin/8199136/webrev.01/
Regards,
Evgeny
[Attachment #3 (text/html)]
<html xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type \
content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 \
(filtered medium)"><style><!-- /* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style></head><body lang=EN-US link=blue vlink=purple><div class=WordSection1><p \
class=MsoNormal>Hi Evgeny,<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p \
class=MsoNormal>The change looks good to me.<o:p></o:p></p><p \
class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Thanks!<o:p></o:p></p><p \
class=MsoNormal>--Daniil<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><div \
style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'><p \
class=MsoNormal><b><span style='font-size:12.0pt;color:black'>From: </span></b><span \
style='font-size:12.0pt;color:black'>serviceability-dev \
<serviceability-dev-bounces@openjdk.java.net> on behalf of Evgeny Mandrikov \
<mandrikov@gmail.com><br><b>Date: </b>Tuesday, September 24, 2019 at 1:32 \
AM<br><b>To: </b>David Holmes <david.holmes@oracle.com><br><b>Cc: \
</b><serviceability-dev@openjdk.java.net><br><b>Subject: </b>Re: RFR: \
JDK-8199136: Dead code in \
src/jdk.jcmd/share/classes/sun/tools/common/ProcessArgumentMatcher.java<o:p></o:p></span></p></div><div><p \
class=MsoNormal><o:p> </o:p></p></div><div><div><div><div><div><div><p \
class=MsoNormal>On Tue, Sep 24, 2019 at 8:15 AM David Holmes <<a \
href="mailto:david.holmes@oracle.com">david.holmes@oracle.com</a>> \
wrote:<o:p></o:p></p></div></div></div></div></div><div><blockquote \
style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in \
6.0pt;margin-left:4.8pt;margin-right:0in'><p class=MsoNormal>I just spotted this \
review request languishing in the mailing list.<o:p></o:p></p></blockquote><div><p \
class=MsoNormal> <o:p></o:p></p></div><blockquote \
style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in \
6.0pt;margin-left:4.8pt;margin-right:0in'><p class=MsoNormal>The patch will need to \
be rebased against latest jdk sources, so please <br>do that. I'll see if I can drum \
up a second reviewer and get a sponsor.<o:p></o:p></p></blockquote><div><p \
class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>Hi \
David,<o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><div><p \
class=MsoNormal>No pb, here is rebased patch - <a \
href="http://cr.openjdk.java.net/~godin/8199136/webrev.01/">http://cr.openjdk.java.net/~godin/8199136/webrev.01/</a><o:p></o:p></p></div><div><p \
class=MsoNormal><o:p> </o:p></p></div><div><p \
class=MsoNormal><o:p> </o:p></p></div><div><p \
class=MsoNormal>Regards,<o:p></o:p></p></div><div><p \
class=MsoNormal>Evgeny<o:p></o:p></p></div></div></div></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic