[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: [8u] [RFR] 8140482: Various minor code improvements (runtime)
From:       Severin Gehwolf <sgehwolf () redhat ! com>
Date:       2019-08-26 14:20:10
Message-ID: ce9d7a4d74cc3bf6f6b484e9014ba93d6161351f.camel () redhat ! com
[Download RAW message or body]

Hi,

On Thu, 2018-11-22 at 08:51 +0000, Lindenmaier, Goetz wrote:
> Hi,
> 
> Doesn't this have to be posted to jdk8u-dev?
> 
> I had a look at the backport. 
> Including 7127191 confused me a bit. Is it good to hide the fact that
> this was backported in the repository?
> In os_linux one fix is missing, is this on purpose? I don't think this is a 
> critical issue, though, so leaving it out is fine.
> 
> > the dropping of the changes to ... 
> > src/share/vm/runtime/task.cpp  and
> > src/os/windows/vm/attachListener_windows.cpp
> These changes are included in the webrev ...?
> 
> The webrev looks good to me.
> 
> Best regards,
>   Goetz.
> 
> 
> 
> 
> 
> > -----Original Message-----
> > From: hotspot-dev <hotspot-dev-bounces@openjdk.java.net> On Behalf Of
> > Andrew Hughes
> > Sent: Mittwoch, 21. November 2018 07:45
> > To: serviceability-dev <serviceability-dev@openjdk.java.net>; hotspot-dev
> > <hotspot-dev@openjdk.java.net>
> > Subject: [8u] [RFR] 8140482: Various minor code improvements (runtime)
> > 
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8140482
> > Original changeset:
> > https://hg.openjdk.java.net/jdk-updates/jdk9u/hotspot/rev/cd86b5699825
> > Webrev:
> > https://cr.openjdk.java.net/~andrew/openjdk8/8140482/webrev.01/
> > 
> > The patch largely applies as is, with some adjustment for context and
> > the dropping of the changes to src/cpu/x86/vm/stubRoutines_x86.cpp,
> > src/share/vm/runtime/task.cpp and
> > src/os/windows/vm/attachListener_windows.cpp
> > which don't exist in 8u. A clean backport of 7127191 is included, which
> > allows the changes to agent/src/os/linux/libproc_impl.c to apply as-is.
> > 
> > Applying the change to 8u improves the code quality there and aids
> > in backporting other changes, such as 8210836 [0].
> > 
> > Ok for 8u?
> > 
> > [0] https://mail.openjdk.java.net/pipermail/serviceability-dev/2018-
> > November/025991.html
> > 
> > Thanks,

Reviving this old thread.

Andrew, could you please rebase this patch to latest 8u? AFAIK, 7127191
has been included since in 8u and the review would be easier if the
webrev didn't show it.

I'd need this backport to go in so as to proceed with JDK-8210836.

Thanks,
Severin

[prev in list] [next in list] [prev in thread] [next in thread]