[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: [8u] [RFR] 8140482: Various minor code improvements (runtime)
From:       Severin Gehwolf <sgehwolf () redhat ! com>
Date:       2019-07-29 14:02:35
Message-ID: 292ecbce64827d6f9596c85aa20587c87f0ca18d.camel () redhat ! com
[Download RAW message or body]

Hi Andrew,

On Wed, 2018-11-21 at 06:45 +0000, Andrew Hughes wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8140482
> Original changeset:
> https://hg.openjdk.java.net/jdk-updates/jdk9u/hotspot/rev/cd86b5699825
> Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8140482/webrev.01/
> 
> The patch largely applies as is, with some adjustment for context and
> the dropping of the changes to src/cpu/x86/vm/stubRoutines_x86.cpp,
> src/share/vm/runtime/task.cpp and src/os/windows/vm/attachListener_windows.cpp
> which don't exist in 8u. A clean backport of 7127191 is included, which
> allows the changes to agent/src/os/linux/libproc_impl.c to apply as-is.

I see that 7127191 is already part of openjdk8u212. Can you rebase your
webrev to jdk8u-dev HEAD, please?

Thanks,
Severin

> Applying the change to 8u improves the code quality there and aids
> in backporting other changes, such as 8210836 [0].
> 
> Ok for 8u?
> 
> [0] https://mail.openjdk.java.net/pipermail/serviceability-dev/2018-November/025991.html
> 
> Thanks,

[prev in list] [next in list] [prev in thread] [next in thread]