[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: JDK-8227693: HTML error in jdwp-protocol.html
From:       "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date:       2019-07-21 19:36:39
Message-ID: 0c839fc0-0081-08eb-0963-589075ae0f1c () oracle ! com
[Download RAW message or body]

+1

Thanks,
Serguei


On 7/20/19 05:44, Daniel D. Daugherty wrote:
> On 7/19/19 6:56 PM, Alex Menkov wrote:
>> Hi all,
>>
>> please review tiny fix for generated jdwp-protocol.html
>> One of the recent fixes added H1 element with incorrect id attribute 
>> value.
>>
>> jira: https://bugs.openjdk.java.net/browse/JDK-8227693
>> webrev: 
>> http://cr.openjdk.java.net/~amenkov/jdk14/jdwp-protocol_space_id/webrev/
>
> make/jdk/src/classes/build/tools/jdwpgen/RootNode.java
>        No comments.
>
> Thumbs up. This qualifies as a trivial fix so only a single
> reviewer is needed and no need to wait 24 hours.
>
> Dan
>
>
>>
>> generated docs:
>> old: 
>> http://cr.openjdk.java.net/~amenkov/jdk14/jdwp-protocol_space_id/0/jdwp-protocol.html
>> new: 
>> http://cr.openjdk.java.net/~amenkov/jdk14/jdwp-protocol_space_id/1/jdwp-protocol.html
>>
>> --alex
>

[prev in list] [next in list] [prev in thread] [next in thread]