'Re: RFR XS,docs,13 JDK-8226593 Fix HTML in com/sun/jdi/doc-files/signature.html'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR XS,docs,13 JDK-8226593 Fix HTML in com/sun/jdi/doc-files/signature.html
From:       "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date:       2019-06-21 19:09:34
Message-ID: fecdd16d-fd4b-f242-c4ae-899f281db232 () oracle ! com
[Download RAW message or body]

Hi Jon,

It looks good to me.

Thanks,
Serguei


On 6/21/19 11:58, Jonathan Gibbons wrote:
> Please review a fix for an accessibility issue reported by Axe in
> src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
>
> The issue is a conflict between an explicit `<div 
> role="main">...`</div>`   specified in the file and the automatic 
> `<main>` added by javadoc.   The fix is just to remove the `<div>` 
> element.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8226593
>
> -- Jon
>
>
> $ hg diff -R open
> diff -r 97c75e545302 
> src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html
> --- a/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html 
> Fri Jun 21 11:41:29 2019 -0700
> +++ b/src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html 
> Fri Jun 21 11:52:35 2019 -0700
> @@ -40,7 +40,6 @@
>   </STYLE>
>   </HEAD>
>   <BODY style="background-color:white">
> -<div role="main">
>   <h1>JDI Type Signatures</h1>
>   <Table Border="0">
>   <caption style="font-size:x-large"><b>JDI Type Signatures</b></caption>
> @@ -74,6 +73,5 @@
>   </pre>has the following type signature:
>   <pre>       (ILjava/lang/String;[I)J
>   </pre>
> -</div>
>   </BODY>
>   </HTML>
>

[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic