[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR: 8225636: SA can't handle prelinked libraries
From: Yasumasa Suenaga <yasuenag () gmail ! com>
Date: 2019-06-17 23:07:31
Message-ID: CAGFVN2AP1fV+FSvoT2D4K8YeiLiD3_8x7BGFk4zfFHY8Kz3MOQ () mail ! gmail ! com
[Download RAW message or body]
Thanks Serguei,
I will push the fix to jdk/jdk later.
Yasumasa
2019=E5=B9=B46=E6=9C=8818=E6=97=A5(=E7=81=AB) 7:49 serguei.spitsyn@oracle.c=
om <serguei.spitsyn@oracle.com>:
> Hi Yasumasa,
>
> I don't think, this needs another review round.
>
> Thanks,
> Serguei
>
> On 6/17/19 15:36, Yasumasa Suenaga wrote:
> > On 2019/06/18 3:33, Chris Plummer wrote:
> >> Looks good other than 1 minor nit. Please remove the blank line at 988=
.
> >
> > I removed it in new webrev. Could you check again?
> > http://cr.openjdk.java.net/~ysuenaga/JDK-8225636/webrev.02/
> >
> >
> > Thanks,
> >
> > Yasumasa
> >
> >
> >> thanks,
> >>
> >> Chris
> >>
> >> On 6/16/19 7:30 AM, Yasumasa Suenaga wrote:
> >>> Hi Serguei, Chris,
> >>>
> >>> Thank you for your comment.
> >>> I uploaded new webrev. Could you review again?
> >>>
> >>> http://cr.openjdk.java.net/~ysuenaga/JDK-8225636/webrev.01/
> >>>
> >>> I separated a function for handling prelinked library.
> >>> Also I added some comments for its process.
> >>>
> >>>
> >>> Thanks,
> >>>
> >>> Yasumasa
> >>>
> >>>
> >>> On 2019/06/15 3:48, Chris Plummer wrote:
> >>>> Hi Yasumasa,
> >>>>
> >>>> I think you should replace the embedded link with more of a textual
> >>>> description of where to look in the gdb source.
> >>>>
> >>>> I'd like to see some short comments. You have a few logical blocks
> >>>> of code that would greatly benefit from just one line saying what
> >>>> they are doing, especially the loop.
> >>>>
> >>>> thanks,
> >>>>
> >>>> Chris
> >>>>
> >>>> On 6/13/19 10:49 PM, Yasumasa Suenaga wrote:
> >>>>> Hi all,
> >>>>>
> >>>>> Please review this change:
> >>>>>
> >>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8225636
> >>>>> webrev:
> >>>>> http://cr.openjdk.java.net/~ysuenaga/JDK-8225636/webrev.00/
> >>>>>
> >>>>> I attempted to open the core which is generated by RHEL 6, but it
> >>>>> could not .
> >>>>>
> >>>>> The OS which generated the core is set to enable prelink.
> >>>>> According to GDB implementation, load address of prelinked library
> >>>>> should be calculated by offset of link_map.l_ld and the address of
> >>>>> .dynamic section.
> >>>>>
> >>>>>
> >>>>> Thanks,
> >>>>>
> >>>>> Yasumasa
> >>>>
> >>>>
> >>
> >>
>
>
[Attachment #3 (text/html)]
<div dir="auto">Thanks Serguei,<div dir="auto"><br></div><div dir="auto">I will push \
the fix to jdk/jdk later.</div><div dir="auto"><br></div><div \
dir="auto"><br></div><div dir="auto">Yasumasa</div><div \
dir="auto"><br></div></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">2019年6月18日(火) 7:49 <a \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a> <<a \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a>>:<br></div><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hi Yasumasa,<br> <br>
I don't think, this needs another review round.<br>
<br>
Thanks,<br>
Serguei<br>
<br>
On 6/17/19 15:36, Yasumasa Suenaga wrote:<br>
> On 2019/06/18 3:33, Chris Plummer wrote:<br>
>> Looks good other than 1 minor nit. Please remove the blank line at 988.<br>
><br>
> I removed it in new webrev. Could you check again?<br>
> <a href="http://cr.openjdk.java.net/~ysuenaga/JDK-8225636/webrev.02/" \
rel="noreferrer noreferrer" \
target="_blank">http://cr.openjdk.java.net/~ysuenaga/JDK-8225636/webrev.02/</a><br> \
><br> ><br>
> Thanks,<br>
><br>
> Yasumasa<br>
><br>
><br>
>> thanks,<br>
>><br>
>> Chris<br>
>><br>
>> On 6/16/19 7:30 AM, Yasumasa Suenaga wrote:<br>
>>> Hi Serguei, Chris,<br>
>>><br>
>>> Thank you for your comment.<br>
>>> I uploaded new webrev. Could you review again?<br>
>>><br>
>>> <a href="http://cr.openjdk.java.net/~ysuenaga/JDK-8225636/webrev.01/" \
rel="noreferrer noreferrer" \
target="_blank">http://cr.openjdk.java.net/~ysuenaga/JDK-8225636/webrev.01/</a><br> \
>>><br> >>> I separated a function for handling prelinked \
library.<br> >>> Also I added some comments for its process.<br>
>>><br>
>>><br>
>>> Thanks,<br>
>>><br>
>>> Yasumasa<br>
>>><br>
>>><br>
>>> On 2019/06/15 3:48, Chris Plummer wrote:<br>
>>>> Hi Yasumasa,<br>
>>>><br>
>>>> I think you should replace the embedded link with more of a textual \
<br> >>>> description of where to look in the gdb source.<br>
>>>><br>
>>>> I'd like to see some short comments. You have a few logical \
blocks <br> >>>> of code that would greatly benefit from just one line \
saying what <br> >>>> they are doing, especially the loop.<br>
>>>><br>
>>>> thanks,<br>
>>>><br>
>>>> Chris<br>
>>>><br>
>>>> On 6/13/19 10:49 PM, Yasumasa Suenaga wrote:<br>
>>>>> Hi all,<br>
>>>>><br>
>>>>> Please review this change:<br>
>>>>><br>
>>>>> JBS: <a \
href="https://bugs.openjdk.java.net/browse/JDK-8225636" rel="noreferrer noreferrer" \
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8225636</a><br> \
>>>>> webrev: <br> >>>>> <a \
href="http://cr.openjdk.java.net/~ysuenaga/JDK-8225636/webrev.00/" rel="noreferrer \
noreferrer" target="_blank">http://cr.openjdk.java.net/~ysuenaga/JDK-8225636/webrev.00/</a><br>
>>>>><br>
>>>>> I attempted to open the core which is generated by RHEL 6, but \
it <br> >>>>> could not .<br>
>>>>><br>
>>>>> The OS which generated the core is set to enable prelink.<br>
>>>>> According to GDB implementation, load address of prelinked \
library<br> >>>>> should be calculated by offset of link_map.l_ld and \
the address of<br> >>>>> .dynamic section.<br>
>>>>><br>
>>>>><br>
>>>>> Thanks,<br>
>>>>><br>
>>>>> Yasumasa<br>
>>>><br>
>>>><br>
>><br>
>><br>
<br>
</blockquote></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic