[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR: 8224252: [TESTBUG] hotspot/test/serviceability/sa/sadebugd/SADebugDTest.java
From: Yasumasa Suenaga <yasuenag () gmail ! com>
Date: 2019-05-24 23:25:04
Message-ID: CAGFVN2Aww4hXHVCBYz6FUafz-73j_64YNLVCKf2M0P_tUPjskQ () mail ! gmail ! com
[Download RAW message or body]
Thanks Serguei and Chris!
Yasumasa
2019年5月25日(土) 5:35 Chris Plummer <chris.plummer@oracle.com>:
> +1
>
> On 5/24/19 8:35 AM, serguei.spitsyn@oracle.com wrote:
>
> Hi Yusamasa,
>
> Thank you for the clarifications!
> It looks good to me.
>
> Thanks,
> Serguei
>
>
> On 5/24/19 03:00, Yasumasa Suenaga wrote:
>
> Hi Serguei,
>
> Other changes are included to improve reliability of testcase.
>
> DebugServer would show "Debugger attached ..." when attach operation is
> completed. So I change its value.
> Then the testcase should wait until debugd process is terminated normaly.
> So I added waitFor() call.
>
> Null check of "app" would be done in stopApp(). So I remove it.
>
>
> Thanks,
>
> Yasumasa
>
> 2019年5月24日(金) 18:44 serguei.spitsyn@oracle.com <serguei.spitsyn@oracle.com
> >:
>
>> Hi Yasumasa,
>>
>> I'm a little bit confused with this fix.
>> If this test is failed on Windows only then the line:
>> + * @requires os.family != "windows"
>>
>> prevents the test to be run on Windows (which looks Okay to me).
>>
>> Then why are there other fixes (excluding the comment with bug numbers)?
>> Your summary below only tells about problem on Windows.
>> What was motivation for these changes?
>>
>> Thanks,
>> Serguei
>>
>>
>> On 5/23/19 17:23, Yasumasa Suenaga wrote:
>>
>> Hi all,
>>
>> Please review this change.
>> This webrev has passed all tests on submit repo
>> (mach5-one-ysuenaga-JDK-8224252-3-20190523-0532-2647154).
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8224252
>> webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8224252/webrev.00/
>>
>> JDK-8163805 was suppose to fix a timeout issue with this test and also
>> removed it off the problemlist. However, it still times out on
>> windows-x64 about 1/3 of the time. It passes every time on all the
>> other platforms.
>>
>> Root cause of this is `jhsdb debugd` could not be exited normally.
>>
>> `jhsdb debugd` (internally, DebugServer.java) would detach from
>> debuggee at shutdown hook. So jhsdb process need to be exited
>> normally.
>> `jhsdb debugd` could not exit itself without external operation (e.g.
>> CTRL+C, signals). Thus we use Process::destroy for it.
>> In the case of Windows, Process::destroy calls TerminateProcess()
>> Windows API to terminate process. However it would terminate target
>> process immediately and it would not give a chance to kick shutdown
>> hook. (It is documented on Javadoc of Runtime::addShutdownHook)
>>
>>
>> Thanks,
>>
>> Yasumasa
>>
>>
>>
>
>
[Attachment #3 (text/html)]
<div dir="auto">Thanks Serguei and Chris!<div dir="auto"><br></div><div \
dir="auto"><br></div><div dir="auto">Yasumasa</div><div \
dir="auto"><br></div></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">2019年5月25日(土) 5:35 Chris Plummer <<a \
href="mailto:chris.plummer@oracle.com">chris.plummer@oracle.com</a>>:<br></div><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<div class="m_-4906766758045351958moz-cite-prefix">+1<br>
</div>
<div class="m_-4906766758045351958moz-cite-prefix"><br>
</div>
<div class="m_-4906766758045351958moz-cite-prefix">On 5/24/19 8:35 AM,
<a class="m_-4906766758045351958moz-txt-link-abbreviated" \
href="mailto:serguei.spitsyn@oracle.com" target="_blank" \
rel="noreferrer">serguei.spitsyn@oracle.com</a> wrote:<br> </div>
<blockquote type="cite">
<div class="m_-4906766758045351958moz-cite-prefix">Hi Yusamasa,<br>
<br>
Thank you for the clarifications!<br>
It looks good to me.<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
On 5/24/19 03:00, Yasumasa Suenaga wrote:<br>
</div>
<blockquote type="cite">
<div dir="auto">
<div dir="auto">Hi Serguei,</div>
<div dir="auto"><br>
</div>
<div dir="auto">Other changes are included to improve
reliability of testcase.</div>
<div dir="auto"><br>
</div>
DebugServer would show "Debugger attached ..." when attach
operation is completed. So I change its value.
<div dir="auto">Then the testcase should wait until debugd
process is terminated normaly. So I added waitFor() call.</div>
<div dir="auto"><br>
</div>
<div dir="auto">Null check of "app" would be done in
stopApp(). So I remove it.</div>
<div dir="auto"><br>
</div>
<div dir="auto"><br>
</div>
<div dir="auto">Thanks,</div>
<div dir="auto"><br>
</div>
<div dir="auto">Yasumasa</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">2019年5月24日(金) 18:44 <a \
href="mailto:serguei.spitsyn@oracle.com" target="_blank" \
rel="noreferrer">serguei.spitsyn@oracle.com</a> <<a \
href="mailto:serguei.spitsyn@oracle.com" target="_blank" \
rel="noreferrer">serguei.spitsyn@oracle.com</a>>:<br> </div>
<blockquote class="gmail_quote">
<div>
<div class="m_-4906766758045351958m_-328939172016723270moz-cite-prefix">Hi
Yasumasa,<br>
<br>
I'm a little bit confused with this fix.<br>
If this test is failed on Windows only then the line:<br>
<span class="m_-4906766758045351958m_-328939172016723270new">+ * \
@requires os.family != "windows"<br>
<br>
prevents the test to be run on Windows (which looks
Okay to me).<br>
<br>
Then why are there other fixes (excluding the comment
with bug numbers)?<br>
Your summary below only tells about problem on
Windows.</span><br>
<span class="m_-4906766758045351958m_-328939172016723270new"><span \
class="m_-4906766758045351958m_-328939172016723270new">What was motivation for these \
changes?<br> <br>
Thanks,<br>
Serguei<br>
<br>
</span></span><br>
On 5/23/19 17:23, Yasumasa Suenaga wrote:<br>
</div>
<blockquote type="cite">
<pre \
class="m_-4906766758045351958m_-328939172016723270moz-quote-pre">Hi all,
Please review this change.
This webrev has passed all tests on submit repo
(mach5-one-ysuenaga-JDK-8224252-3-20190523-0532-2647154).
JBS: <a class="m_-4906766758045351958m_-328939172016723270moz-txt-link-freetext" \
href="https://bugs.openjdk.java.net/browse/JDK-8224252" rel="noreferrer noreferrer" \
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8224252</a> webrev: <a \
class="m_-4906766758045351958m_-328939172016723270moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/~ysuenaga/JDK-8224252/webrev.00/" rel="noreferrer \
noreferrer" target="_blank">http://cr.openjdk.java.net/~ysuenaga/JDK-8224252/webrev.00/</a>
JDK-8163805 was suppose to fix a timeout issue with this test and also
removed it off the problemlist. However, it still times out on
windows-x64 about 1/3 of the time. It passes every time on all the
other platforms.
Root cause of this is `jhsdb debugd` could not be exited normally.
`jhsdb debugd` (internally, DebugServer.java) would detach from
debuggee at shutdown hook. So jhsdb process need to be exited
normally.
`jhsdb debugd` could not exit itself without external operation (e.g.
CTRL+C, signals). Thus we use Process::destroy for it.
In the case of Windows, Process::destroy calls TerminateProcess()
Windows API to terminate process. However it would terminate target
process immediately and it would not give a chance to kick shutdown
hook. (It is documented on Javadoc of Runtime::addShutdownHook)
Thanks,
Yasumasa
</pre>
</blockquote>
<br>
</div>
</blockquote>
</div>
</blockquote>
<br>
</blockquote>
<p><br>
</p>
</div>
</blockquote></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic