[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: RE: RFR(S): 8224230: [PPC64, s390] Support AsyncGetCallTrace
From: "Doerr, Martin" <martin.doerr () sap ! com>
Date: 2019-05-21 7:40:17
Message-ID: AM6PR02MB4788C81902D60C72C630A4819A070 () AM6PR02MB4788 ! eurprd02 ! prod ! outlook ! com
[Download RAW message or body]
[Attachment #2 (text/plain)]
Hi Serguei,
thanks for the review.
Best regards,
Martin
From: serviceability-dev <serviceability-dev-bounces@openjdk.java.net> On Behalf Of \
serguei.spitsyn@oracle.com
Sent: Dienstag, 21. Mai 2019 05:55
To: Jean Christophe Beyler <jcbeyler@google.com>; Lindenmaier, Goetz \
<goetz.lindenmaier@sap.com>
Cc: serviceability-dev@openjdk.java.net
Subject: Re: RFR(S): 8224230: [PPC64, s390] Support AsyncGetCallTrace
Hi Martin,
LGTM++
Thanks,
Serguei
On 5/20/19 09:34, Jean Christophe Beyler wrote:
Hi Martin,
Looks good to me too :)
Jc
On Mon, May 20, 2019 at 8:56 AM Lindenmaier, Goetz \
<goetz.lindenmaier@sap.com<mailto:goetz.lindenmaier@sap.com>> wrote: LGTM
Goetz!
> -----Original Message-----
> From: Doerr, Martin
> Sent: Montag, 20. Mai 2019 17:49
> To: Lindenmaier, Goetz \
> <goetz.lindenmaier@sap.com<mailto:goetz.lindenmaier@sap.com>>; serviceability- \
> dev@openjdk.java.net<mailto:dev@openjdk.java.net>; JC Beyler \
> <jcbeyler@google.com<mailto:jcbeyler@google.com>>; Volker Simonis \
> (volker.simonis@gmail.com<mailto:volker.simonis@gmail.com>) \
> <volker.simonis@gmail.com<mailto:volker.simonis@gmail.com>>
> Subject: RE: RFR(S): 8224230: [PPC64, s390] Support AsyncGetCallTrace
>
> Hi Götz,
>
> thanks for reviewing it so quickly.
>
> Thanks for pointing me to the obsolete comment. I've also fixed in on PPC64
> and also removed a redundant assertion on PPC64:
> http://cr.openjdk.java.net/~mdoerr/8224230_ppc_s390_AsyncCallTrace/webr
> ev.01/
>
> I haven't used async profiler, but I've ran JTREG tests for hotspot runtime on
> linux PPC64 (Big and Little Endian) and s390 and all ones have passed.
>
> Best regards,
> Martin
>
>
> -----Original Message-----
> From: Lindenmaier, Goetz
> Sent: Montag, 20. Mai 2019 17:36
> To: Doerr, Martin <martin.doerr@sap.com<mailto:martin.doerr@sap.com>>; \
> serviceability- dev@openjdk.java.net<mailto:dev@openjdk.java.net>; JC Beyler \
> <jcbeyler@google.com<mailto:jcbeyler@google.com>>; Volker Simonis \
> (volker.simonis@gmail.com<mailto:volker.simonis@gmail.com>) \
> <volker.simonis@gmail.com<mailto:volker.simonis@gmail.com>>
> Subject: RE: RFR(S): 8224230: [PPC64, s390] Support AsyncGetCallTrace
>
> Hi Martin,
>
> the changes look good.
>
> Please fix this comment:
> // Forte Analyzer AsyncGetCallTrace profiling support is not implemented on
> Linux/S390x.
> I guess it's no more true. No new webrev needed.
>
> Did you verify that the test works, or did you also try
> async with the VM on ppc?
>
> Best regards,
> Goetz.
>
> > -----Original Message-----
> > From: Doerr, Martin
> > Sent: Montag, 20. Mai 2019 17:32
> > To: serviceability-dev@openjdk.java.net<mailto:serviceability-dev@openjdk.java.net>; \
> > JC Beyler <jcbeyler@google.com<mailto:jcbeyler@google.com>>; Volker Simonis \
> > (volker.simonis@gmail.com<mailto:volker.simonis@gmail.com>) \
> > <volker.simonis@gmail.com<mailto:volker.simonis@gmail.com>>; Lindenmaier, Goetz \
> > <goetz.lindenmaier@sap.com<mailto:goetz.lindenmaier@sap.com>>
> > Subject: RFR(S): 8224230: [PPC64, s390] Support AsyncGetCallTrace
> >
> > Hi,
> >
> >
> >
> > please review my change which allows usage of AsyncGetCallTrace on PPC64
> > and s390.
> >
> >
> >
> > Webrev:
> >
> >
> http://cr.openjdk.java.net/~mdoerr/8224230_ppc_s390_AsyncCallTrace/webr
> > ev.00/
> >
> >
> >
> > Bug with more background information:
> >
> > https://bugs.openjdk.java.net/browse/JDK-8224230
> >
> >
> >
> > Best regards,
> >
> > Martin
> >
> >
--
Thanks,
Jc
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"> <head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body bgcolor="white" lang="DE" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US">Hi
</span>Serguei,<o:p></o:p></p>
<p class="MsoNormal"><span \
style="color:windowtext;mso-fareast-language:EN-US"><o:p> </o:p></span></p> <p \
class="MsoNormal"><span lang="EN-US" \
style="color:windowtext;mso-fareast-language:EN-US">thanks for the \
review.<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US" \
style="color:windowtext;mso-fareast-language:EN-US"><o:p> </o:p></span></p> <p \
class="MsoNormal"><span style="color:windowtext;mso-fareast-language:EN-US">Best \
regards,<o:p></o:p></span></p> <p class="MsoNormal"><span \
style="color:windowtext;mso-fareast-language:EN-US">Martin<o:p></o:p></span></p> <p \
class="MsoNormal"><span \
style="color:windowtext;mso-fareast-language:EN-US"><o:p> </o:p></span></p> <p \
class="MsoNormal"><span \
style="mso-fareast-language:EN-US"><o:p> </o:p></span></p> <div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" \
style="color:windowtext">From:</span></b><span lang="EN-US" style="color:windowtext"> \
serviceability-dev <serviceability-dev-bounces@openjdk.java.net> <b>On Behalf \
Of </b>serguei.spitsyn@oracle.com<br> <b>Sent:</b> Dienstag, 21. Mai 2019 05:55<br>
<b>To:</b> Jean Christophe Beyler <jcbeyler@google.com>; Lindenmaier, Goetz \
<goetz.lindenmaier@sap.com><br> <b>Cc:</b> \
serviceability-dev@openjdk.java.net<br> <b>Subject:</b> Re: RFR(S): 8224230: [PPC64, \
s390] Support AsyncGetCallTrace<o:p></o:p></span></p> </div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Hi Martin,<br>
<br>
LGTM++<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
On 5/20/19 09:34, Jean Christophe Beyler wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">Hi Martin, <o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Looks good to me too :)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Jc<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Mon, May 20, 2019 at 8:56 AM Lindenmaier, Goetz <<a \
href="mailto:goetz.lindenmaier@sap.com">goetz.lindenmaier@sap.com</a>> \
wrote:<o:p></o:p></p> </div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal" style="margin-bottom:12.0pt">LGTM<br>
Goetz!<br>
<br>
> -----Original Message-----<br>
> From: Doerr, Martin<br>
> Sent: Montag, 20. Mai 2019 17:49<br>
> To: Lindenmaier, Goetz <<a href="mailto:goetz.lindenmaier@sap.com" \
target="_blank">goetz.lindenmaier@sap.com</a>>; serviceability-<br> > <a \
href="mailto:dev@openjdk.java.net" target="_blank">dev@openjdk.java.net</a>; JC \
Beyler <<a href="mailto:jcbeyler@google.com" \
target="_blank">jcbeyler@google.com</a>>; Volker Simonis<br> > (<a \
href="mailto:volker.simonis@gmail.com" target="_blank">volker.simonis@gmail.com</a>) \
<<a href="mailto:volker.simonis@gmail.com" \
target="_blank">volker.simonis@gmail.com</a>><br> > Subject: RE: RFR(S): \
8224230: [PPC64, s390] Support AsyncGetCallTrace<br> > <br>
> Hi Götz,<br>
> <br>
> thanks for reviewing it so quickly.<br>
> <br>
> Thanks for pointing me to the obsolete comment. I've also fixed in on PPC64<br>
> and also removed a redundant assertion on PPC64:<br>
> <a href="http://cr.openjdk.java.net/~mdoerr/8224230_ppc_s390_AsyncCallTrace/webr" \
target="_blank"> http://cr.openjdk.java.net/~mdoerr/8224230_ppc_s390_AsyncCallTrace/webr</a><br>
> ev.01/<br>
> <br>
> I haven't used async profiler, but I've ran JTREG tests for hotspot runtime \
on<br> > linux PPC64 (Big and Little Endian) and s390 and all ones have \
passed.<br> > <br>
> Best regards,<br>
> Martin<br>
> <br>
> <br>
> -----Original Message-----<br>
> From: Lindenmaier, Goetz<br>
> Sent: Montag, 20. Mai 2019 17:36<br>
> To: Doerr, Martin <<a href="mailto:martin.doerr@sap.com" \
target="_blank">martin.doerr@sap.com</a>>; serviceability-<br> > <a \
href="mailto:dev@openjdk.java.net" target="_blank">dev@openjdk.java.net</a>; JC \
Beyler <<a href="mailto:jcbeyler@google.com" \
target="_blank">jcbeyler@google.com</a>>; Volker Simonis<br> > (<a \
href="mailto:volker.simonis@gmail.com" target="_blank">volker.simonis@gmail.com</a>) \
<<a href="mailto:volker.simonis@gmail.com" \
target="_blank">volker.simonis@gmail.com</a>><br> > Subject: RE: RFR(S): \
8224230: [PPC64, s390] Support AsyncGetCallTrace<br> > <br>
> Hi Martin,<br>
> <br>
> the changes look good.<br>
> <br>
> Please fix this comment:<br>
> // Forte Analyzer AsyncGetCallTrace profiling support is not implemented \
on<br> > Linux/S390x.<br>
> I guess it's no more true. No new webrev needed.<br>
> <br>
> Did you verify that the test works, or did you also try<br>
> async with the VM on ppc?<br>
> <br>
> Best regards,<br>
> Goetz.<br>
> <br>
> > -----Original Message-----<br>
> > From: Doerr, Martin<br>
> > Sent: Montag, 20. Mai 2019 17:32<br>
> > To: <a href="mailto:serviceability-dev@openjdk.java.net" \
target="_blank">serviceability-dev@openjdk.java.net</a>; JC Beyler <<a \
href="mailto:jcbeyler@google.com" target="_blank">jcbeyler@google.com</a>>;<br> \
> > Volker Simonis (<a href="mailto:volker.simonis@gmail.com" \
target="_blank">volker.simonis@gmail.com</a>) <<a \
href="mailto:volker.simonis@gmail.com" \
target="_blank">volker.simonis@gmail.com</a>>;<br> > > Lindenmaier, Goetz \
<<a href="mailto:goetz.lindenmaier@sap.com" \
target="_blank">goetz.lindenmaier@sap.com</a>><br> > > Subject: RFR(S): \
8224230: [PPC64, s390] Support AsyncGetCallTrace<br> > ><br>
> > Hi,<br>
> ><br>
> ><br>
> ><br>
> > please review my change which allows usage of AsyncGetCallTrace on \
PPC64<br> > > and s390.<br>
> ><br>
> ><br>
> ><br>
> > Webrev:<br>
> ><br>
> ><br>
> <a href="http://cr.openjdk.java.net/~mdoerr/8224230_ppc_s390_AsyncCallTrace/webr" \
target="_blank"> http://cr.openjdk.java.net/~mdoerr/8224230_ppc_s390_AsyncCallTrace/webr</a><br>
> > ev.00/<br>
> ><br>
> ><br>
> ><br>
> > Bug with more background information:<br>
> ><br>
> > <a href="https://bugs.openjdk.java.net/browse/JDK-8224230" \
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8224230</a><br> > \
><br> > ><br>
> ><br>
> > Best regards,<br>
> ><br>
> > Martin<br>
> ><br>
> ><o:p></o:p></p>
</blockquote>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p class="MsoNormal">-- <o:p></o:p></p>
<div>
<div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p class="MsoNormal">Thanks, <o:p></o:p></p>
<div>
<p class="MsoNormal">Jc<o:p></o:p></p>
</div>
</div>
</div>
</blockquote>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic